Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[storage.blob] Remove aiohttp as dependency for storage.blob.aio #24965

Merged
merged 17 commits into from
Jul 1, 2022

Conversation

Stevenjin8
Copy link
Contributor

@Stevenjin8 Stevenjin8 commented Jun 23, 2022

Description

aio/_download_async.py used to import aiohttp.client_exceptions.ClientPayloadError to catch it if it was raised by the transport. The client should be agnostic to the transport implementation hence not import this error. Also, the AioHttpTransportResponse already catches aiohttp.client_exceptions.ClientPayloadError so this exception should never be raised by the transport.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Jun 23, 2022
@Stevenjin8 Stevenjin8 changed the title [storage.blolb] Remove aiohttp as implicit dependency for storage.blob.aio [storage.blob] Remove aiohttp as implicit dependency for storage.blob.aio Jun 23, 2022
@azure-sdk
Copy link
Collaborator

azure-sdk commented Jun 23, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-eventgrid
azure-communication-identity
azure-storage-file-share

@Stevenjin8 Stevenjin8 marked this pull request as ready for review June 24, 2022 00:24
@Stevenjin8 Stevenjin8 changed the title [storage.blob] Remove aiohttp as implicit dependency for storage.blob.aio [storage.blob] Remove aiohttp as dependency for storage.blob.aio Jun 24, 2022
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

Copy link
Member

@jalauzon-msft jalauzon-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up!

@Stevenjin8 Stevenjin8 force-pushed the fix/storage-aiohttp-dependency branch from 5ee567b to 5f340c0 Compare June 29, 2022 00:27
Copy link
Member

@vincenttran-msft vincenttran-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching this and also promptly getting a PR out 😄

@Stevenjin8 Stevenjin8 force-pushed the fix/storage-aiohttp-dependency branch from efcb33e to d1d7fef Compare July 1, 2022 03:38
@lmazuel lmazuel merged commit e40d3e1 into main Jul 1, 2022
@lmazuel lmazuel deleted the fix/storage-aiohttp-dependency branch July 1, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants