-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[storage.blob] Remove aiohttp as dependency for storage.blob.aio #24965
Conversation
API change check APIView has identified API level changes in this PR and created following API reviews. azure-eventgrid |
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this up!
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_download_async.py
Show resolved
Hide resolved
…re-sdk-for-python into fix/storage-aiohttp-dependency
5ee567b
to
5f340c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for catching this and also promptly getting a PR out 😄
efcb33e
to
d1d7fef
Compare
Description
aio/_download_async.py
used to importaiohttp.client_exceptions.ClientPayloadError
to catch it if it was raised by the transport. The client should be agnostic to the transport implementation hence not import this error. Also, theAioHttpTransportResponse
already catchesaiohttp.client_exceptions.ClientPayloadError
so this exception should never be raised by the transport.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines