Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update change_log #23742

Merged
merged 4 commits into from
Mar 30, 2022
Merged

update change_log #23742

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fda48bd
update change_log
Wzb123456789 Mar 30, 2022
566a04a
Update change_log.py
Wzb123456789 Mar 30, 2022
c851c77
Update tools/azure-sdk-tools/packaging_tools/change_log.py
msyyc Mar 30, 2022
de18e10
Update tools/azure-sdk-tools/packaging_tools/change_log.py
msyyc Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tools/azure-sdk-tools/packaging_tools/change_log.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def operation(self, diff_entry):
return

# Is this a new operation, inside a known operation group?
function_name, *remaining_path = remaining_path
function_name, change_parameter_name, *remaining_path = remaining_path
if not remaining_path:
if is_deletion:
self.breaking_changes.append(_REMOVE_OPERATION.format(operation_name, function_name))
Expand All @@ -80,7 +80,7 @@ def operation(self, diff_entry):
return

# So method signaure changed. Be vague for now
self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name))
self.breaking_changes.append(_SIGNATURE_CHANGE.format(operation_name, function_name, change_parameter_name))

def models(self, diff_entry):
path, is_deletion = self._unpack_diff_entry(diff_entry)
Expand Down Expand Up @@ -144,7 +144,7 @@ def models(self, diff_entry):
## Breaking Changes
_REMOVE_OPERATION_GROUP = "Removed operation group {}"
_REMOVE_OPERATION = "Removed operation {}.{}"
_SIGNATURE_CHANGE = "Operation {}.{} has a new signature"
_SIGNATURE_CHANGE = "Operation {}.{} has a new signature {}"
_MODEL_SIGNATURE_CHANGE = "Model {} has a new signature"
_MODEL_PARAM_DELETE = "Model {} no longer has parameter {}"
_MODEL_PARAM_ADD_REQUIRED = "Model {} has a new required parameter {}"
Expand Down