Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Fix generated code for service operations #23570

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

jalauzon-msft
Copy link
Member

@jalauzon-msft jalauzon-msft commented Mar 17, 2022

The previous update to the generated code from the new version of autorest in #23497 broke any Service Operations where the URL path was just / in the Swagger. This was due to a bug in a newly introduced directive. This was causing Live Test auth failures for any tests involving a Service Operation.

This change fixes the directive and re-generates code for all packages.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Mar 17, 2022
Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jalauzon-msft !

@jalauzon-msft
Copy link
Member Author

/azp run python - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jalauzon-msft
Copy link
Member Author

Failing live tests due to known issue with azure-core will override and merge

1 similar comment
@jalauzon-msft
Copy link
Member Author

Failing live tests due to known issue with azure-core will override and merge

@jalauzon-msft
Copy link
Member Author

/azp run python - storage - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jalauzon-msft
Copy link
Member Author

Live test failure was known flaky test. Will override.

@jalauzon-msft
Copy link
Member Author

/check-enforcer override

@jalauzon-msft jalauzon-msft merged commit c472b93 into Azure:main Mar 21, 2022
@jalauzon-msft jalauzon-msft deleted the fix-generated-code branch March 21, 2022 17:48
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants