Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SB tests to env loader #23566

Closed
wants to merge 7 commits into from
Closed

SB tests to env loader #23566

wants to merge 7 commits into from

Conversation

rakshith91
Copy link
Contributor

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Service Bus label Mar 17, 2022
@rakshith91
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000248711C3070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000021147D63070>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024870CA1D80>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000021147841DB0>, 

@rakshith91
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000248711C3070>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002A4BF183070>, 
-             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000024870CA1D80>, 
+             filter: Union[CorrelationRuleFilter, SqlRuleFilter] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000002A4BEC61D80>, 

@rakshith91
Copy link
Contributor Author

/azp run python - servicebus - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Apr 2, 2022

API change check for azure-servicebus

API changes have been detected in azure-servicebus. You can review API changes here

API changes

-             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000270FA407370>, 
+             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x000001516643F340>, 
-             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x00000270F9F17A60>, 
+             filter: Optional[Union[CorrelationRuleFilter, SqlRuleFilter]] = <azure.servicebus.management._models.TrueRuleFilter object at 0x0000015165F47A90>, 

@rakshith91
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rakshith91
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Jun 10, 2022
@ghost
Copy link

ghost commented Jun 10, 2022

Hi @rakshith91. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Jun 17, 2022
@ghost
Copy link

ghost commented Jun 17, 2022

Hi @rakshith91. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@rakshith91 rakshith91 reopened this Jun 21, 2022
@rakshith91
Copy link
Contributor Author

/reopen

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Jun 21, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 2, 2022

Hi @rakshith91. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Sep 9, 2022
@ghost
Copy link

ghost commented Sep 9, 2022

Hi @rakshith91. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-recent-activity There has been no recent activity on this issue. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants