Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync eng/common directory with azure-sdk-tools for PR 2778 #23268

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Sync eng/common directory with azure-sdk-tools for PR 2778 #23268

merged 2 commits into from
Mar 2, 2022

Conversation

azure-sdk
Copy link
Collaborator

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#2778 See eng/common workflow

@azure-sdk azure-sdk requested a review from sima-zhu March 1, 2022 22:32
@azure-sdk azure-sdk added Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system. labels Mar 1, 2022
@azure-sdk azure-sdk force-pushed the sync-eng/common-cleanup-2778 branch from e3f03fb to 0418adc Compare March 1, 2022 23:49
@check-enforcer
Copy link

check-enforcer bot commented Mar 1, 2022

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@azure-sdk azure-sdk force-pushed the sync-eng/common-cleanup-2778 branch from 0418adc to e7c623c Compare March 2, 2022 00:40
@azure-sdk azure-sdk merged commit e022426 into main Mar 2, 2022
@azure-sdk azure-sdk deleted the sync-eng/common-cleanup-2778 branch March 2, 2022 05:41
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 7, 2022
@azure-sdk @sima-zhu @rakshith91
Sync eng/common directory with azure-sdk-tools for PR 2778 (Azure#23268)
14af1d1 
* Clean up unused codes and dependencies

* fix the only deleted files

Co-authored-by: sima-zhu <[email protected]>
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@azure-sdk @sima-zhu @rakshith91
Sync eng/common directory with azure-sdk-tools for PR 2778 (Azure#23268)
64b98ef 
* Clean up unused codes and dependencies

* fix the only deleted files

Co-authored-by: sima-zhu <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this pull request Apr 18, 2023
@Kartik-715 @cakarata
@payalguptapg @AnshulVermaa @Sandido @younghyun5756 @krishnak-msft @linugeorgeofficial @vatsan28 @vivlingaiah @mimckitt
CodeGen from PR 22885 in Azure/azure-rest-api-specs
ca0419f 
Feature/cplat 2023 03 01 (Azure#22885)

* copy last version to 2023-03-01 folder

* update version reference in the new folder

* update versions reference in the new folder

* add new readme tag with new version

* sync with updates made to 2022-11-01 version

* fix generation error

* fix duplicate enum name thru c# directive instead.

* make all the changes to this version that was made to the last version (2022-11-01) to address modelvalidation errors

* update

* Revert "update"

This reverts commit 08417d3ed412ab63c7ee7bdb712ad756ded03c97.

* Added $expand option in ListAllVMs and ListAllVMs in RG (Azure#22800)

* Added $expand option in ListAllVMs and ListAllVMs in RG

* Update virtualMachine.json

* dedicatedHost Resize feature (Azure#23268)

* dedicatedHost Resize feature

* DedicatedHost Sku renamed to size and resolved lint errors.

* reviewer comments

* httpMethod fix

* Add property for VM (Azure#22882) (Azure#23329)

Co-authored-by: payalguptapg <[email protected]>

* Add Reapply for VMSS (Azure#22344)

* Add Reapply for VMSS

* Prettier fix

* Update examples

* Address review comments 01

* Use typical resourceGroupName parameter.

* Address review comments - Rename examples

* Remove <br> syntax from many descriptions in CRP swagger files (Azure#23019)

* up to computeRPCommon

* all but computeRPCommons

* computerpcommon

* vmss clean

* common clean

* vmss try n

* trying only \n

* remove \n as it messes with rest docs

* cleanup 2022-11-01 accidents

* cleanups 2023

* remove ID from Update objects that do not have ID (Azure#23078)

* update

* add identifiers

---------

Co-authored-by: Theodore Chang <[email protected]>

* Origin/feature/cplat 2023 03 01 (Azure#23203)

* Update virtualMachine.json

Added missing property for 
Additional properties not allowed: provisionAfterExtensions
Json path: $.value[*].properties.provisionAfterExtensions

* added missing property for provisionAfterExtensions

* add locatoin in VirtualMachineScaleSetVMExtension

* fixed issue of x-ms-mutability

---------

Co-authored-by: Younghyun Kim <[email protected]>

* Add securityPostureReference (Azure#23106)

* [RestorePoints] Adding Encryption, Source Details, HyperVGeneration and WriteAccelerated for Restore Point (Azure#23303)

* Restore Point Encryption Details

* Modified descriptions and made DiskRestorePointProperties as input property

* Renaming object and adding type

* Renaming DiskRestorePointProperties

* making DiskRestorePoint.id readOnly

* Modifying reference

* Running Prettier

* Renaming EncryptionType

* Adding HyperVGeneration and WriteAcceleratorEnabled (prchin)

* Add optional parameter hibernate to vmss deallocate api (Azure#23409)

* Add optional parameter hibernate to vmss deallocate api

* Fix with prettier

* update example for vmss deallocate

* Add Spot Related Properties to VMSS PATCH

* prettier and lintDiff suppressions

* retry lintDiff suppression

* lint diff suppression retry

* Add managed identities parameters for blobs, add treatFailureAsDeploymentFailure flag for Run Command (Azure#23557)

* Add managed identities inputs for script, errorBlob, outputBlob

* Add treatFailureAsDeploymentFailure flag

* Update proximityPlacementGroup.json (Azure#23556)

* Update proximityPlacementGroup.json

* Update proximityPlacementGroup.json

* Update proximityPlacementGroup.json

---------

Co-authored-by: Theodore Chang <[email protected]>
Co-authored-by: Kartik Gupta <[email protected]>
Co-authored-by: cakarata <[email protected]>
Co-authored-by: payalguptapg <[email protected]>
Co-authored-by: Anshul Verma <[email protected]>
Co-authored-by: Adam Sandor <[email protected]>
Co-authored-by: younghyun5756 <[email protected]>
Co-authored-by: Younghyun Kim <[email protected]>
Co-authored-by: krishnak-msft <[email protected]>
Co-authored-by: Linu George <[email protected]>
Co-authored-by: vatsan28 <[email protected]>
Co-authored-by: Viv Lingaiah <[email protected]>
Co-authored-by: Micah McKittrick <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sima-zhu sima-zhu sima-zhu approved these changes

@scbedd scbedd Awaiting requested review from scbedd

@weshaggard weshaggard Awaiting requested review from weshaggard

@benbp benbp Awaiting requested review from benbp

Assignees

@sima-zhu sima-zhu

Labels
Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azure-sdk @sima-zhu