[Cosmos] Add max_integrated_cache_staleness param option to item methods #22946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Gahl Levy <[email protected]>
Co-authored-by: Gahl Levy <[email protected]>
…n consistency to start client session
…ded (thanks Jake!)
Kushagra improved documentation and comments Co-authored-by: Kushagra Thapar <[email protected]>
…-sdk-for-python into integrated-cache
ghost
added
the
annatisch
reviewed
Feb 21, 2022
|
API changes have been detected in |
simorenoh
added
Do Not Merge
Client
|
API changes have been detected in |
… out these changes will also likely be used for creating the diagnostics later on
kushagraThapar
approved these changes
Mar 4, 2022
|
@simorenoh - was this PR only blocked because of me, if so, apologies for late approval. Please merge it if it is ready. If not, let me know what we need to do to get it in. Thanks! |
|
API changes have been detected in |
kushagraThapar
requested changes
Mar 9, 2022
sdk/cosmos/azure-cosmos/azure/cosmos/_cosmos_client_connection.py
Outdated
Show resolved
Hide resolved
kushagraThapar
approved these changes
Mar 9, 2022
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 7, 2022
…ods (Azure#22946) * consistency level gets set to default found in database account * async client default change * updated docs based on finding and updated samples to reflect best practices * Update CHANGELOG.md * Update README.md * Update README.md * Update README.md * Update CHANGELOG.md * formatting * formatting * updated consistency for first request to Eventual (lowest latency) * pylint * from_connection_string methods * from_connection_string2 * Update sdk/cosmos/azure-cosmos/README.md Co-authored-by: Gahl Levy <[email protected]> * Apply suggestions from code review Co-authored-by: Gahl Levy <[email protected]> * Update README.md * removed forceful header usage, changed setup to only check for Session consistency to start client session * need to set header if Session consistency for updating session if needed (thanks Jake!) * Apply suggestions from code review Kushagra improved documentation and comments Co-authored-by: Kushagra Thapar <[email protected]> * added test for session token * Update CHANGELOG.md * Update _cosmos_client_connection_async.py * added max_integrated_cache_staleness to item methods in containers * added validation and provisional comments * pylint * only applied to read-only operations * Update container.py * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: Kushagra Thapar <[email protected]> * Update _base.py * updated param comments to mention integrated cache configuration * moved to kwargs * added tests to verify functionality * Update test_integrated_cache.py * Update test_integrated_cache.py * updates to test to ensure it works with setup * added headers test and new way to track client headers before sending out these changes will also likely be used for creating the diagnostics later on * Update test_integrated_cache.py * Create test_axq.py * Added mocking tests for max integrated cache staleness. Fixed issue with int value being false * upgrade version for release Co-authored-by: Gahl Levy <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]>
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
…ods (Azure#22946) * consistency level gets set to default found in database account * async client default change * updated docs based on finding and updated samples to reflect best practices * Update CHANGELOG.md * Update README.md * Update README.md * Update README.md * Update CHANGELOG.md * formatting * formatting * updated consistency for first request to Eventual (lowest latency) * pylint * from_connection_string methods * from_connection_string2 * Update sdk/cosmos/azure-cosmos/README.md Co-authored-by: Gahl Levy <[email protected]> * Apply suggestions from code review Co-authored-by: Gahl Levy <[email protected]> * Update README.md * removed forceful header usage, changed setup to only check for Session consistency to start client session * need to set header if Session consistency for updating session if needed (thanks Jake!) * Apply suggestions from code review Kushagra improved documentation and comments Co-authored-by: Kushagra Thapar <[email protected]> * added test for session token * Update CHANGELOG.md * Update _cosmos_client_connection_async.py * added max_integrated_cache_staleness to item methods in containers * added validation and provisional comments * pylint * only applied to read-only operations * Update container.py * Update CHANGELOG.md * Apply suggestions from code review Co-authored-by: Kushagra Thapar <[email protected]> * Update _base.py * updated param comments to mention integrated cache configuration * moved to kwargs * added tests to verify functionality * Update test_integrated_cache.py * Update test_integrated_cache.py * updates to test to ensure it works with setup * added headers test and new way to track client headers before sending out these changes will also likely be used for creating the diagnostics later on * Update test_integrated_cache.py * Create test_axq.py * Added mocking tests for max integrated cache staleness. Fixed issue with int value being false * upgrade version for release Co-authored-by: Gahl Levy <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]> Co-authored-by: Kushagra Thapar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it so users can start trying out the CosmosDB integrated cache in the Python SDK with either the sync or async clients. These changes are basically just passing in additional headers.
Still missing marking these headers as a preview feature. We currently have the SDK in beta version while we work in the async client, but we can't have so many beta versions in a row for the SDK - users shy away from using beta versions, even if not all of it is in beta. We should find a way to make sure we communicate this is a preview header, but the client itself should be good to use.