Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 2.7/3.5 #22760

Merged
merged 13 commits into from
Feb 3, 2022
Merged

Drop support for Python 2.7/3.5 #22760

merged 13 commits into from
Feb 3, 2022

Conversation

AikoBB
Copy link
Member

@AikoBB AikoBB commented Jan 25, 2022 •
edited
Loading

Description

Packaging and documentation updates for dropping Python 2.7/3.5 for communication packages
Resolves #20691

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added the Communication label Jan 25, 2022
petrsvihlik
petrsvihlik suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@petrsvihlik petrsvihlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we edit readmes and changelogs of all acs modalities to include the disclaimer?

@tjprescott
Copy link
Member

I believe we are required to keep 3.6 support for the time being. @lmazuel

@lmazuel
Copy link
Member

lmazuel commented Jan 25, 2022

@AikoBB indeed, we have to finally support 3.6 a little longer

@AikoBB AikoBB marked this pull request as draft January 26, 2022 10:32
This was referenced Jan 27, 2022
Closed
Closed
@AriZavala2
Copy link
Contributor

/azp run python - azure-communication-networktraversal - tests

@azure-pipelines
Copy link

Pull request contains merge conflicts.

AriZavala2
AriZavala2 approved these changes Jan 29, 2022
View reviewed changes
Copy link
Contributor

@AriZavala2 AriZavala2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, can we just run the live tests before?

@AikoBB
Copy link
Member Author

AikoBB commented Jan 31, 2022

/azp run python - azure-communication-networktraversal - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AikoBB
Copy link
Member Author

AikoBB commented Jan 31, 2022 •
edited
Loading

/azp run python - azure-communication-identity - tests

@AikoBB
Copy link
Member Author

AikoBB commented Jan 31, 2022 •
edited
Loading

/azp run python - azure-communication-phonenumbers - tests

@AikoBB
Copy link
Member Author

AikoBB commented Jan 31, 2022 •
edited
Loading

/azp run python - azure-communication-sms - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AikoBB
Copy link
Member Author

AikoBB commented Jan 31, 2022

/azp run python - azure-communication-chat - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AikoBB AikoBB requested a review from lucasrsant February 1, 2022 13:35
@AikoBB AikoBB requested a review from lucasrsant February 2, 2022 08:05
@petrsvihlik petrsvihlik merged commit 41e81c8 into Azure:main Feb 3, 2022
@AikoBB AikoBB deleted the aigerimb/acs-identity/drop_2.7_3.6 branch March 9, 2022 09:37
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@AikoBB @rakshith91
Drop support for Python 2.7/3.5 (Azure#22760)
642f089 
* updates to drop 2.7/3.5 support

* mgmt setup.py fix

* cspell fix for azuremgmtcommunication

* removing nspkg from dev requirements all communication packages

* versions update for communication packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmazuel lmazuel lmazuel approved these changes

@AriZavala2 AriZavala2 AriZavala2 approved these changes

@LuChen-Microsoft LuChen-Microsoft LuChen-Microsoft approved these changes

@arifibrahim4 arifibrahim4 arifibrahim4 approved these changes

@petrsvihlik petrsvihlik petrsvihlik approved these changes

@lucasrsant lucasrsant lucasrsant approved these changes

@AlonsoMondal AlonsoMondal Awaiting requested review from AlonsoMondal

@benbp benbp Awaiting requested review from benbp

@BigCat20196 BigCat20196 Awaiting requested review from BigCat20196

@danielav7 danielav7 Awaiting requested review from danielav7 danielav7 is a code owner

@msyyc msyyc Awaiting requested review from msyyc msyyc is a code owner

@RoyHerrod RoyHerrod Awaiting requested review from RoyHerrod

@scbedd scbedd Awaiting requested review from scbedd

@whisper6284 whisper6284 Awaiting requested review from whisper6284 whisper6284 is a code owner

@martinbarnas-ms martinbarnas-ms Awaiting requested review from martinbarnas-ms

@juancamilor juancamilor Awaiting requested review from juancamilor

@miguhern miguhern Awaiting requested review from miguhern miguhern is a code owner

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure SDK Python packages support for Python 2.7 is ending 01 January 2022
8 participants
@AikoBB @tjprescott @lmazuel @AriZavala2 @lucasrsant @petrsvihlik @arifibrahim4 @LuChen-Microsoft