Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address astroid / wrapt installation error output #22746

Merged
merged 5 commits into from
Jan 25, 2022

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Jan 25, 2022

@mccoyp @kristapratico while this is not failing any builds at this point in time, we are seeing some error output that isn't failing the builds.

Example Build

We've been seeing this error on and off in our builds, sometimes associated with another issue #22489 , sometimes on its own.

The origin of this error is two packages.

  1. vcrpy~=3.0.0 from azure-devtools setup.py -> wrapt
  2. pylint==2.5.2 from test_tools.txt. pylint==2.5.2 -> astroid==2.5 -> wrapt >=1.12,<1.13

Checking the setup for vcrpy, we can see that wrapt is actually totally unpinned. This means that it's an order of installation problem.

If vcrpy is installed first, wrapt will install at the latest, then during installation of pylint, 1.12.1 version actually is installed. This means that there is no conflict, and everything is fine.

If, however, pylint is installed first, wrapt==1.11.1 is installed, then supplanted by the vcrpy install. THIS is where the ERROR text pops up. We lucked into a situation where we're not actually using any functionalities that break, which is why we don't see this associated with any failed builds.

I'm not absolutely certain why we're triggering this logic, as its not consistent. IMO, it should recognize that there is a wrapt installation already completed. I think we're hitting edge cases in the old pip==20.3 resolver.

By pinning wrapt to the version required by astroid==2.5, I believe we should be able to eliminate this warning.

eng/tox/tox.ini Outdated Show resolved Hide resolved
@scbedd scbedd merged commit 7661e71 into Azure:main Jan 25, 2022
@scbedd scbedd self-assigned this Jan 25, 2022
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Jan 25, 2022
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
* pin wrapt to earlier version to force the right decision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants