Address astroid / wrapt installation error output #22746
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mccoyp @kristapratico while this is not failing any builds at this point in time, we are seeing some error output that isn't failing the builds.
Example Build
We've been seeing this error on and off in our builds, sometimes associated with another issue #22489 , sometimes on its own.
The origin of this error is two packages.
vcrpy~=3.0.0
from azure-devtools setup.py ->wrapt
pylint==2.5.2
from test_tools.txt.pylint==2.5.2
->astroid==2.5
->wrapt >=1.12,<1.13
Checking the setup for vcrpy, we can see that
wrapt
is actually totally unpinned. This means that it's an order of installation problem.If
vcrpy
is installed first,wrapt
will install at the latest, then during installation ofpylint
,1.12.1
version actually is installed. This means that there is no conflict, and everything is fine.If, however,
pylint
is installed first,wrapt==1.11.1
is installed, then supplanted by thevcrpy
install. THIS is where theERROR
text pops up. We lucked into a situation where we're not actually using any functionalities that break, which is why we don't see this associated with any failed builds.I'm not absolutely certain why we're triggering this logic, as its not consistent. IMO, it should recognize that there is a
wrapt
installation already completed. I think we're hitting edge cases in the old pip==20.3 resolver.By pinning
wrapt
to the version required byastroid==2.5
, I believe we should be able to eliminate this warning.