Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[metricsadvisor] Update async samples to use asyncio.run() #22269

Merged
merged 1 commit into from
Jan 4, 2022
Merged

[metricsadvisor] Update async samples to use asyncio.run() #22269

merged 1 commit into from
Jan 4, 2022

Conversation

sammiee5311
Copy link
Contributor

Description

related to #21211

drop loop.run_untill_complete to use asyncio.run().

Thanks!

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@ghost ghost added Cognitive - Metrics Advisor customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Dec 28, 2021
@ghost
Copy link

ghost commented Dec 28, 2021

Thank you for your contribution sammiee5311! We will review the pull request and get back to you soon.

kristapratico
kristapratico approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sammiee5311, thanks for your PR! This looks good to me, but I'm going to wait for @xiangyan99's review before merging. :)

xiangyan99
xiangyan99 approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@xiangyan99 xiangyan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good to me. Thanks for the contribution!

@kristapratico kristapratico merged commit dcfedb8 into Azure:main Jan 4, 2022
@sammiee5311 sammiee5311 deleted the update-metricsadvisor-samples branch January 5, 2022 00:53
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@sammiee5311 @rakshith91
[metricsadvisor] Update async samples to use asyncio.run() (Azure#22269)
e1c107e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@xiangyan99 xiangyan99 xiangyan99 approved these changes

Assignees
No one assigned
Labels
Cognitive - Metrics Advisor customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sammiee5311 @xiangyan99 @kristapratico