Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventHubs] Fix bug in reusing EventHubProducerClient #21927

Merged

Conversation

yunhaoling
Copy link
Contributor

Addressing issue: #21849

fix EventHubProducerClient reusability

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob-aio. You can review API changes here

API changes

-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 
-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob. You can review API changes here

API changes

-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 
-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 

@check-enforcer
Copy link

check-enforcer bot commented Dec 1, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@yunhaoling
Copy link
Contributor Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling yunhaoling requested a review from swathipil January 3, 2022 22:47
Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit, but o/w LGTM!

sdk/eventhub/azure-eventhub/CHANGELOG.md Outdated Show resolved Hide resolved
@yunhaoling
Copy link
Contributor Author

/azp run python - eventhub - tests

@ghost
Copy link

ghost commented Jan 3, 2022

Hello @yunhaoling!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling yunhaoling merged commit 811cf03 into Azure:main Jan 4, 2022
@yunhaoling yunhaoling deleted the yuling/eh/fix-producer-reusability branch January 4, 2022 17:49
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
* fix bug

* run black

* fix mypy

* fix pylint

* update changelog to be more clear

* Update sdk/eventhub/azure-eventhub/CHANGELOG.md

Co-authored-by: swathipil <[email protected]>

Co-authored-by: swathipil <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants