Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR] containerservices/resource-manager #2186

Merged
merged 9 commits into from
Jun 5, 2018

Conversation

AutorestCI
Copy link
Contributor

Created to accumulate context: containerservices/resource-manager

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Mar 15, 2018

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-containerservice

You can install the package azure-mgmt-containerservice of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_containerservices/resource-manager#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_containerservices/resource-manager#egg=azure-mgmt-containerservice&subdirectory=azure-mgmt-containerservice"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_containerservices/resource-manager
  • pip install -e ./azure-mgmt-containerservice

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_containerservices/resource-manager
  • pip wheel --no-deps ./azure-mgmt-containerservice

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Mar 15, 2018

Codecov Report

Merging #2186 into master will decrease coverage by 0.43%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2186      +/-   ##
==========================================
- Coverage   56.09%   55.65%   -0.44%     
==========================================
  Files        6979     7194     +215     
  Lines      147807   152652    +4845     
==========================================
+ Hits        82906    84964    +2058     
- Misses      64901    67688    +2787
Impacted Files Coverage Δ
.../models/container_service_ssh_configuration_py3.py 100% <100%> (ø)
...vice/models/container_service_linux_profile_py3.py 100% <100%> (ø)
.../mgmt/containerservice/models/container_service.py 100% <100%> (ø) ⬆️
...t/containerservice/models/container_service_py3.py 100% <100%> (ø)
...ice/models/container_service_ssh_public_key_py3.py 100% <100%> (ø)
...dels/container_service_orchestrator_profile_py3.py 100% <100%> (ø)
...inerservice/azure/mgmt/containerservice/version.py 100% <100%> (ø) ⬆️
...rservice/models/container_service_linux_profile.py 100% <100%> (ø) ⬆️
...vice/models/container_service_ssh_configuration.py 100% <100%> (ø) ⬆️
...ice/azure/mgmt/containerservice/models/__init__.py 100% <100%> (ø) ⬆️
... and 400 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3110473...73d742a. Read the comment docs.

@lmazuel
Copy link
Member

lmazuel commented May 25, 2018

@AutorestCI rebase

[AKS] specify byte format for base64-encoded kubeconfig
…or fetching accessProfiles (#2583)

* Generated from 3c1665f522ece941d8c827b3e8ee539c2cdaf846

[AKS] add POST endpoint for fetching accessProfiles

* Generated from a86af5dd1b974ecc3b58e95efc228497137d79a3

Mark GET endpoint for accessProfiles as deprecated

* Generated from 14544bfbd10b7319f64f1174b84801347ace5dc9

Bump package version

* Generated from a69eb4b470374683c3bc4e86491aa60ae0a161ea

Rename to GetAccessProfile
@AutorestCI AutorestCI force-pushed the restapi_auto_containerservices/resource-manager branch from 2cc6d9d to afba301 Compare May 25, 2018 21:21
@AutorestCI
Copy link
Contributor Author

Rebase done and pushed to the branch

@lmazuel
Copy link
Member

lmazuel commented May 25, 2018

@AutorestCI
Copy link
Contributor Author

Encountered a Subprocess error

Command: ['/usr/local/bin/autorest', '/tmp/tmprmd_0a58/rest/specification/containerservices/resource-manager/readme.md', '--multiapi', '--python', '--python-mode=update', '--python-sdks-folder=/tmp/tmprmd_0a58/sdk', '[email protected]/autorest.python@~3.0', '--version=preview']
Finished with return code 1
and output:

AutoRest code generation utility [version: 2.0.4262; node: v7.10.1]
(C) 2018 Microsoft Corporation.
https://aka.ms/autorest
   Loading AutoRest core      '/root/.autorest/@[email protected]/node_modules/@microsoft.azure/autorest-core/dist' (2.0.4279)
   Loading AutoRest extension '@microsoft.azure/autorest.python' (~3.0->3.0.51)
   Loading AutoRest extension '@microsoft.azure/autorest.modeler' (2.3.44->2.3.44)

ERROR (Fatal/DuplicateModelCollsion): Duplicated model name with non-identical definitions
    - file:///tmp/tmprmd_0a58/rest/specification/containerservices/resource-manager/Microsoft.ContainerService/stable/2017-08-31/managedClusters.json:753:4 ($.definitions.ContainerServiceAgentPoolProfile)
    - file:///tmp/tmprmd_0a58/rest/specification/containerservices/resource-manager/Microsoft.ContainerService/stable/2017-07-01/containerService.json:632:4 ($.definitions.ContainerServiceAgentPoolProfile)
Process() cancelled due to exception : Cancellation requested.
  Cancellation requested.

…API (#2631)

* Generated from e365e10741ba688b8c3b39b67986e2b6e06e4ddc

Rename to ManagedClusterAgentPoolProfile.

Its fields have diverged from ContainerServiceAgentPoolProfile.

* Generated from 3047e9e632f7c44d4a88f3c768fc1de4dd9f40ec

Py version

* Generated from d61dfda40f6a7498040fee441c1b23cb6a1bc01a

Incorporated review comments
@mboersma
Copy link
Member

mboersma commented Jun 1, 2018

@lmazuel is the Subprocess error above still an issue now that the swagger is merged? I see a similar issue in Travis CI at https://travis-ci.org/Azure/azure-rest-api-specs/jobs/386372774.

I'm wondering if I need to make a PR to reconcile the OSType definitions in the older v20180831 AKS API as well, now that we're being stricter in linting.

@lmazuel
Copy link
Member

lmazuel commented Jun 1, 2018

@Azure Azure deleted a comment from AutorestCI Jun 1, 2018
@AutorestCI
Copy link
Contributor Author

Nothing to rebuild, this PR is up to date

@lmazuel
Copy link
Member

lmazuel commented Jun 1, 2018

@mboersma I asked the bot to rebuild, you see it's saying now "Nothing to rebuild, this PR is up to date" which means he was able to generate the code and found no errors nor new things to generate.

Considering Python itself, there is no more PR to do for OSType

Rename to "Operation" from "ComputeOperation"
@mboersma
Copy link
Member

mboersma commented Jun 5, 2018

This looks good to me. I'm not sure what the process is now--how can we get this merged and published to pypi? See also the CLI PR.

@lmazuel lmazuel merged commit ce29625 into master Jun 5, 2018
@lmazuel lmazuel deleted the restapi_auto_containerservices/resource-manager branch June 5, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants