Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes for TestProxy LiveTesting #21828

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Nov 19, 2021

Copy link
Contributor

@rakshith91 rakshith91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rakshith91 rakshith91 merged commit 59022e5 into Azure:main Nov 19, 2021
@v-xuto v-xuto self-requested a review November 19, 2021 07:00
@@ -86,6 +86,9 @@ parameters:
- name: PlatformPostSteps
type: object
default: []
- name: TestProxy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@v-xuto
Copy link
Member

v-xuto commented Nov 19, 2021

@scbedd There is a problem with indentation in file eng/pipelines/templates/stages/archetype-sdk-tests.yml, there should be a space in front. Maybe it should be changed as shown below.
The same problem also exists in file eng/pipelines/templates/jobs/live.tests.yml. Please take a look.
image

I found this error when I ran the pipeline.
image

rakshith91 added a commit that referenced this pull request Nov 19, 2021
weshaggard pushed a commit that referenced this pull request Nov 19, 2021
@scbedd
Copy link
Member Author

scbedd commented Nov 19, 2021

@v-xuto this was not merged by me, apologies for the issues. Thanks @rakshith91 for reverting the original merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants