-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Perf] Add PerfTestBase and BatchPerfTest #21812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't review the code line-by-line, but the APIs look correct.
I recommend adding a sample test that extends BatchPerfTest, something like https://github.com/Azure/azure-sdk-for-net/pull/24653/files#diff-5ebbae98f50d4148984513195f10702a48ae2b56dfbfaa9220b591c88b710978.
I also recommend running a few real-world tests like blop upload/download/list-blobs to verify no change in results.
Thanks @mikeharder - I added that sample to the documentation, and ran the blob storage tests (with and without proxy) |
How do you feel about adding the sample |
Sure thing. Added. |
Fixes #20816
Fixes #21384
Fixes #21159