-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update EventHub to enable live testing in sovereign clouds for multiple services #21715
Conversation
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
@yunhaoling @benbp I rerun a new weekly pipeline, test(test_auth.py::test_client_secret_credential) failed in UsGov and China clouds. Error is: |
@v-xuto you may need to add another RBAC policy in the ARM template test-resources.json file? However some quick internet searching indicates that this error may be misleading, and it's actually a missing password? https://stackoverflow.com/a/68833937 I would try adding the claim first in this array and see if that fixes the issue: https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/eventhub/test-resources.json#L189-L215 The role id can be found here and is |
@benbp I run this test(test_auth.py::test_client_secret_credential) locally, and I also encounter the same permission problem. So, I debug the test code and set the breakpoint after the eventhub and other resources are created. After the resources are created, I go to the portal to find the corresponding eventhub and add permissions( |
@benbp What is your progress on this issue ( |
@v-xuto sorry for the delay I was on vacation. Have you tried updating the RBAC assignments in the ARM template similar to the examples I linked? |
@benbp I have tried updating the RBAC assignments in the ARM template, it still reports the same error. For more details please check here. @yunhaoling Any ideas about this issue( |
@benbp @swathipil Now, rerun the Event Hub weekly pipeline, there is a new issue here. When running tests( Do you have any ideas to solve this issue? |
/azp run python - eventhub - tests |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run python - eventhub - tests |
No pipelines are associated with this pull request. |
/azp run python - eventhub - tests |
/azp run python - eventhub - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
Azure Pipelines successfully started running 1 pipeline(s). |
green EH tests-weekly pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2613023&view=results |
Hello @swathipil! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
These changes enable Event Hub to run live tests against Public, UsGov and China.
@benbp , @jameszliao-msft , @lmazuel , @lilyjma , @ramya-rao-a, @annatisch for notification.