Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use arm template parameters as sole input for live test environment variables #21693

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Nov 10, 2021

For sovereign cloud testing, many cloud-specific arm template parameters and environment variables get passed in from an external keyvault source. This makes them hard to manage and track. I plan to move these values into source control, and as a pre-requisite I am consolidating as many values into the arm template parameters as possible (as opposed to a mismash of parameters and env var declarations).

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for Key Vault

@benbp
Copy link
Member Author

benbp commented Nov 10, 2021

/azp run python - attestation - tests

@benbp benbp requested review from weshaggard and ckairen November 10, 2021 21:00
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp benbp force-pushed the benbp/live-test-vars branch from 37a26d0 to 63617f3 Compare November 12, 2021 19:09
@benbp
Copy link
Member Author

benbp commented Nov 12, 2021

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Nov 12, 2021

/azp run python - keyvault - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benbp
Copy link
Member Author

benbp commented Nov 15, 2021

Some managed HSM test timeouts (likely due to region overlaps), but the live tests are looking good.

@benbp
Copy link
Member Author

benbp commented Nov 15, 2021

/check-enforcer override

@benbp benbp merged commit 664855a into Azure:main Nov 15, 2021
@benbp benbp deleted the benbp/live-test-vars branch November 15, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. KeyVault Tables
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants