Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate CLI factory in azure-common #21337

Merged
merged 11 commits into from
Feb 2, 2022
Merged

Deprecate CLI factory in azure-common #21337

merged 11 commits into from
Feb 2, 2022

Conversation

lmazuel
Copy link
Member

@lmazuel lmazuel commented Oct 19, 2021

See #20657 and #21313

@ghost ghost added the Azure.Core label Oct 19, 2021
frank-lsf
frank-lsf reviewed Oct 19, 2021
View reviewed changes
Copy link

@frank-lsf frank-lsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

@frank-lsf frank-lsf mentioned this pull request Oct 19, 2021
Closed
2 tasks
@lmazuel
Copy link
Member Author

lmazuel commented Oct 19, 2021 •
edited
Loading

image

Since this screenshot I changed it to NotImplementedError

This was referenced Oct 19, 2021
Closed
Closed
@scbedd
Copy link
Member

scbedd commented Oct 19, 2021

@praveenkuttappan APIView is getting its environments confused.

@praveenkuttappan
Copy link
Member

API diff is a false alarm here since source branch in this case doesn't have recent change on main in storage packages. So artifact in this PR doesn't have this recent change which confuses APIView and flags it as removed in this PR. I will have a fix submitted to skip API check in PR if package is not modified. Currently this is triggered based on pipeline which doesn't make any sense for API check if source files are not modified.

@lmazuel lmazuel force-pushed the cli_factory_deprecation branch from f2be066 to cbe29c4 Compare December 16, 2021 22:23
annatisch
annatisch reviewed Dec 16, 2021
View reviewed changes
@lmazuel lmazuel mentioned this pull request Dec 16, 2021
Closed
@Azure Azure deleted a comment from azure-sdk Dec 16, 2021
@Azure Azure deleted a comment from azure-sdk Dec 16, 2021
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob-aio. You can review API changes here

API changes

-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ..., 
-             api_version: str, 
+             api_version: str = ..., 
-             secondary_hostname: str, 
+             secondary_hostname: str = ...,

@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-eventhub-checkpointstoreblob. You can review API changes here

API changes

-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ..., 
-             api_version: str, 
-             secondary_hostname: str, 
+             api_version: str = ..., 
+             secondary_hostname: str = ...,

@lmazuel lmazuel mentioned this pull request Dec 17, 2021
Closed
@lmazuel
Copy link
Member Author

lmazuel commented Dec 17, 2021

/azp run python - tables - ci

@lmazuel
Copy link
Member Author

lmazuel commented Dec 17, 2021

/azp run python - core - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmazuel
Copy link
Member Author

lmazuel commented Dec 17, 2021

/azp run python - communication - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lmazuel lmazuel force-pushed the cli_factory_deprecation branch from d0e6566 to 82aa9ad Compare January 28, 2022 00:46
@azure-sdk
Copy link
Collaborator

API changes have been detected in azure-cosmos. You can review API changes here

@xiangyan99
Copy link
Member

None of the failures is related to the change.

@xiangyan99
Copy link
Member

/check-enforcer override

@xiangyan99 xiangyan99 merged commit 13950c4 into main Feb 2, 2022
@xiangyan99 xiangyan99 deleted the cli_factory_deprecation branch February 2, 2022 01:43
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Apr 10, 2022
@lmazuel @xiangyan99 @rakshith91
Deprecate CLI factory in azure-common (Azure#21337)
b9a0af0 
* Deprecate CLI factory in azure-common

* Correct syntax

* ChangeLog

* NotImplementedError

* Deprecate all CLI related methods

* Rewording

* Date change

* Typo thanks @annatisch

* Typo

* Fix tests

* Update CHANGELOG.md

Co-authored-by: Xiang Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frank-lsf frank-lsf frank-lsf left review comments

@johanste johanste johanste left review comments

@annatisch annatisch annatisch approved these changes

@rakshith91 rakshith91 Awaiting requested review from rakshith91

@xiangyan99 xiangyan99 Awaiting requested review from xiangyan99

Assignees
No one assigned
Labels
Azure.Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lmazuel @scbedd @praveenkuttappan @azure-sdk @xiangyan99 @frank-lsf @annatisch @johanste