Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR policyinsights/resource-manager/policyinsights/resource-manager/Microsoft.PolicyInsights/PolicyStates/policyinsights/resource-manager/Microsoft.PolicyInsights/PolicyEvents] Swagger specs for all existing versions of Microsoft.PolicyInsights #2026

Closed
wants to merge 4 commits into from

Conversation

AutorestCI
Copy link
Contributor

Swagger specs for all existing versions of Microsoft.PolicyInsights
@codecov-io
Copy link

codecov-io commented Feb 21, 2018

Codecov Report

Merging #2026 into master will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2026      +/-   ##
==========================================
+ Coverage   53.05%   53.11%   +0.06%     
==========================================
  Files        4772     4774       +2     
  Lines      119449   119685     +236     
==========================================
+ Hits        63376    63574     +198     
- Misses      56073    56111      +38
Impacted Files Coverage Δ
...-commerce/azure/mgmt/commerce/models/info_field.py 66.66% <0%> (-13.34%) ⬇️
...merce/azure/mgmt/commerce/models/error_response.py 64.28% <0%> (-5.72%) ⬇️
...mgmt/commerce/models/rate_card_query_parameters.py 50% <0%> (-5.56%) ⬇️
...commerce/operations/usage_aggregates_operations.py 25.92% <0%> (-2.28%) ⬇️
...e/mgmt/commerce/operations/rate_card_operations.py 100% <0%> (ø) ⬆️
...-commerce/azure/mgmt/commerce/models/meter_info.py 100% <0%> (ø) ⬆️
...re/mgmt/commerce/models/resource_rate_card_info.py 100% <0%> (ø) ⬆️
...erce/azure/mgmt/commerce/models/offer_term_info.py 100% <0%> (ø) ⬆️
azure-mgmt-managementgroups/azure/mgmt/__init__.py 100% <0%> (ø)
azure-mgmt-managementgroups/azure/__init__.py 100% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13ad6a9...bf035fb. Read the comment docs.

Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions
Fix additionalParameters definition; fix duplicate paths
Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle)
@lmazuel
Copy link
Member

lmazuel commented Feb 28, 2018

policyinsights will be regenerated if necessary for Python, let's close this one with a bad title for now

@lmazuel lmazuel closed this Feb 28, 2018
@lmazuel lmazuel deleted the restapi_auto_2523 branch February 28, 2018 19:06
@bulentelmaci
Copy link

@lmazuel Should I manually generate (via autorest) and start a PR then?

@lmazuel
Copy link
Member

lmazuel commented Feb 28, 2018

Hi @bulentelmaci ! Do you plan more work on this soon, or you think it's ready for a preview release?

@bulentelmaci
Copy link

@lmazuel I might need to do one minor change to swagger, and then it will be ready. should I generate it, start a PR and ping you then? it will be in a few days..

@lmazuel
Copy link
Member

lmazuel commented Feb 28, 2018

Ok, then do your new Swagger PR, and we generate SDK from there. You see at the title here, we have a small issue in context detection to fix. Yours should be "policyinsights/resource-manager". Next automatic PR will include this one and your future fix.
Sounds good?

@bulentelmaci
Copy link

Sorry, about the context detection issue you mentioned, not sure what I need to do. I assume it is a fix you need to do? If not, could you ping me at Skype ([email protected])?

@lmazuel
Copy link
Member

lmazuel commented Feb 28, 2018

You have nothing to do, that's our CI. We discuss right now if your folder structure is fine or not (should it be Microsoft.Features/PolicyStates/preview or Microsoft.Features/preview/PolicyStates). This will help me to decide how to fix the CI, and anyway it's not on you since documentation didn't help you to decide.
If we decide that the current folder structure is not what we want, we will move your Swagger for you. Please double-check that when you'll do the next PR.
Sorry for the confusion here...

@bulentelmaci
Copy link

Got it. Thanks! I will do a small PR in azure-rest-api-specs and once that goes in, I will start .NET and Phyton SDK generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants