-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoPR policyinsights/resource-manager/policyinsights/resource-manager/Microsoft.PolicyInsights/PolicyStates/policyinsights/resource-manager/Microsoft.PolicyInsights/PolicyEvents] Swagger specs for all existing versions of Microsoft.PolicyInsights #2026
Conversation
Swagger specs for all existing versions of Microsoft.PolicyInsights
Codecov Report
@@ Coverage Diff @@
## master #2026 +/- ##
==========================================
+ Coverage 53.05% 53.11% +0.06%
==========================================
Files 4772 4774 +2
Lines 119449 119685 +236
==========================================
+ Hits 63376 63574 +198
- Misses 56073 56111 +38
Continue to review full report at Codecov.
|
Remove EQUIVALENT_PATH suppressions; add extendedProperties as additionalProperties; add @odata.count to operations; remove "type" from "rows" in first 2017-08-09-preview and add descriptions
Fix additionalParameters definition; fix duplicate paths
Remove redundant operations path/definitions from one of the swagger files for each version (one per namespace is sufficient as long as both files are fed into autorest as a bundle)
policyinsights will be regenerated if necessary for Python, let's close this one with a bad title for now |
@lmazuel Should I manually generate (via autorest) and start a PR then? |
Hi @bulentelmaci ! Do you plan more work on this soon, or you think it's ready for a preview release? |
@lmazuel I might need to do one minor change to swagger, and then it will be ready. should I generate it, start a PR and ping you then? it will be in a few days.. |
Ok, then do your new Swagger PR, and we generate SDK from there. You see at the title here, we have a small issue in context detection to fix. Yours should be "policyinsights/resource-manager". Next automatic PR will include this one and your future fix. |
Sorry, about the context detection issue you mentioned, not sure what I need to do. I assume it is a fix you need to do? If not, could you ping me at Skype ([email protected])? |
You have nothing to do, that's our CI. We discuss right now if your folder structure is fine or not (should it be |
Got it. Thanks! I will do a small PR in azure-rest-api-specs and once that goes in, I will start .NET and Phyton SDK generation. |
Created to sync Azure/azure-rest-api-specs#2523