Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[packaging] Include license in PyPi packages #20193

Merged
merged 2 commits into from
Oct 14, 2021
Merged

[packaging] Include license in PyPi packages #20193

merged 2 commits into from
Oct 14, 2021

Conversation

major
Copy link
Contributor

@major major commented Aug 9, 2021

The MIT license requires that a copy of the license is distributed with
the software. Add the license to the template and also add it to the
manifest file.

Fixes: #20183

Signed-off-by: Major Hayden [email protected]

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Aug 9, 2021
@ghost
Copy link

ghost commented Aug 9, 2021

Thank you for your contribution major! We will review the pull request and get back to you soon.

@major
Copy link
Contributor Author

major commented Aug 9, 2021

Trying this instead of fixing each package individually as mentioned by @lmazuel in #20183.

The MIT license requires that a copy of the license is distributed with
the software. Add the license to the template and also add it to the
manifest file.

Fixes: #20183

Signed-off-by: Major Hayden <[email protected]>
@xiangyan99
Copy link
Member

@scbedd could you help to take a look?

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick, but looks good!

Thanks for the contribution @major !

@xiangyan99
Copy link
Member

Given the author gave thumbsup, we would commit the suggestion and merge the PR.

Please feel free to add comments if you have concerns. @major

Thanks again for your contribution.

@major
Copy link
Contributor Author

major commented Oct 14, 2021

Feel free to do whatever is needed! Thanks!

@scbedd
Copy link
Member

scbedd commented Oct 14, 2021

/check-enforcer override

@scbedd scbedd merged commit 9ac7834 into Azure:main Oct 14, 2021
@major major deleted the add-license-to-template branch October 15, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azure-mgmt-sql: LICENSE missing from PyPi
3 participants