-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[packaging] Include license in PyPi packages #20193
Conversation
Thank you for your contribution major! We will review the pull request and get back to you soon. |
The MIT license requires that a copy of the license is distributed with the software. Add the license to the template and also add it to the manifest file. Fixes: #20183 Signed-off-by: Major Hayden <[email protected]>
@scbedd could you help to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tiny nitpick, but looks good!
Thanks for the contribution @major !
Given the author gave thumbsup, we would commit the suggestion and merge the PR. Please feel free to add comments if you have concerns. @major Thanks again for your contribution. |
Feel free to do whatever is needed! Thanks! |
Co-authored-by: Scott Beddall <[email protected]>
/check-enforcer override |
The MIT license requires that a copy of the license is distributed with
the software. Add the license to the template and also add it to the
manifest file.
Fixes: #20183
Signed-off-by: Major Hayden [email protected]