cut hard dependency on requests #19930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run python - identity - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Jul 30, 2021
| ]) | ||
| try: |
There was a problem hiding this comment.
Could we add comments to all the the try/except blocks here? The logic is a little hard to follow :)
| @@ -99,6 +99,8 @@ def _case_insensitive_dict(*args, **kwargs): | |||
| # multidict is installed by aiohttp | |||
| from multidict import CIMultiDict | |||
|
|
|||
| if len(kwargs) == 0 and len(args) == 1 and (not args[0]): | |||
There was a problem hiding this comment.
What's args[0] in this case? Maybe add a small comment as to what this if-statement is addressing?
There was a problem hiding this comment.
This is to handle case_insensitive_dict(None). requests.structures.CaseInsensitiveDict returns empty dict while multidict.CIMultiDict raise error.
Here we want to return dict().
annatisch
approved these changes
Jul 30, 2021
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Aug 2, 2021
…into add_chardet_dep * 'main' of https://github.com/Azure/azure-sdk-for-python: (35 commits) `azure-applicationinsights` Hyperlinks need sphinx style formatting (Azure#19993) update version and changelog (Azure#20034) Rename AZURE_POD_IDENTITY_TOKEN_URL -> AZURE_POD_IDENTITY_AUTHORITY_HOST (Azure#19867) add sample for raw_response_hook (Azure#19985) cut hard dependency on requests (Azure#19930) Update ci.yml (Azure#20028) Update ci.yml (Azure#20026) Update PythonSdkLiveTest.yml (Azure#19999) [AutoRelease] t2-recoveryservicessiterecovery-2021-07-28-40357 (Azure#19970) [AutoRelease] t2-storagecache-2021-07-29-63871 (Azure#19987) Minor changes in docs (Azure#20016) Add Logs Batch query results (Azure#20013) Rename query (Azure#19952) d218371 (Azure#20009) Update CHANGELOG.md (Azure#20006) [Batch] Data plane SDK v11.0.0 (Azure#19889) [AutoRelease] t2-batch-2021-07-30-27488 (Azure#19996) add ga id to index (Azure#19995) Edit pass on Monitor Query README file (Azure#19979) Move stress testing scripts to eng/common (Azure#19994) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.