-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix a few simple typos #19127
docs: fix a few simple typos #19127
Conversation
There are small typos in: - doc/dev/mgmt/generation.md - sdk/applicationinsights/azure-applicationinsights/azure/applicationinsights/models/error_response.py - sdk/applicationinsights/azure-applicationinsights/azure/applicationinsights/models/error_response_py3.py - sdk/batch/azure-batch/azure/batch/models/_models.py - sdk/batch/azure-batch/azure/batch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-anomalydetector/azure/cognitiveservices/anomalydetector/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-anomalydetector/azure/cognitiveservices/anomalydetector/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-formrecognizer/azure/cognitiveservices/formrecognizer/models/error_response.py - sdk/cognitiveservices/azure-cognitiveservices-formrecognizer/azure/cognitiveservices/formrecognizer/models/error_response_py3.py - sdk/cognitiveservices/azure-cognitiveservices-knowledge-qnamaker/azure/cognitiveservices/knowledge/qnamaker/models/error_response.py - sdk/cognitiveservices/azure-cognitiveservices-knowledge-qnamaker/azure/cognitiveservices/knowledge/qnamaker/models/error_response_py3.py - sdk/cognitiveservices/azure-cognitiveservices-language-luis/azure/cognitiveservices/language/luis/authoring/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-language-luis/azure/cognitiveservices/language/luis/authoring/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-language-luis/azure/cognitiveservices/language/luis/runtime/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-language-luis/azure/cognitiveservices/language/luis/runtime/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/azure/cognitiveservices/language/spellcheck/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-language-spellcheck/azure/cognitiveservices/language/spellcheck/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-language-textanalytics/azure/cognitiveservices/language/textanalytics/models/error_response.py - sdk/cognitiveservices/azure-cognitiveservices-language-textanalytics/azure/cognitiveservices/language/textanalytics/models/error_response_py3.py - sdk/cognitiveservices/azure-cognitiveservices-personalizer/azure/cognitiveservices/personalizer/models/error_response.py - sdk/cognitiveservices/azure-cognitiveservices-personalizer/azure/cognitiveservices/personalizer/models/error_response_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-autosuggest/azure/cognitiveservices/search/autosuggest/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-autosuggest/azure/cognitiveservices/search/autosuggest/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-customimagesearch/azure/cognitiveservices/search/customimagesearch/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-customimagesearch/azure/cognitiveservices/search/customimagesearch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-customsearch/azure/cognitiveservices/search/customsearch/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-customsearch/azure/cognitiveservices/search/customsearch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-entitysearch/azure/cognitiveservices/search/entitysearch/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-entitysearch/azure/cognitiveservices/search/entitysearch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-imagesearch/azure/cognitiveservices/search/imagesearch/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-imagesearch/azure/cognitiveservices/search/imagesearch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-newssearch/azure/cognitiveservices/search/newssearch/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-newssearch/azure/cognitiveservices/search/newssearch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-videosearch/azure/cognitiveservices/search/videosearch/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-videosearch/azure/cognitiveservices/search/videosearch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-visualsearch/azure/cognitiveservices/search/visualsearch/models/error_response.py - sdk/cognitiveservices/azure-cognitiveservices-search-visualsearch/azure/cognitiveservices/search/visualsearch/models/error_response_py3.py - sdk/cognitiveservices/azure-cognitiveservices-search-websearch/azure/cognitiveservices/search/websearch/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-search-websearch/azure/cognitiveservices/search/websearch/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-vision-computervision/azure/cognitiveservices/vision/computervision/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-vision-computervision/azure/cognitiveservices/vision/computervision/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-vision-contentmoderator/azure/cognitiveservices/vision/contentmoderator/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-vision-contentmoderator/azure/cognitiveservices/vision/contentmoderator/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-vision-customvision/azure/cognitiveservices/vision/customvision/prediction/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-vision-customvision/azure/cognitiveservices/vision/customvision/prediction/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-vision-customvision/azure/cognitiveservices/vision/customvision/training/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-vision-customvision/azure/cognitiveservices/vision/customvision/training/models/_models_py3.py - sdk/cognitiveservices/azure-cognitiveservices-vision-face/azure/cognitiveservices/vision/face/models/_models.py - sdk/cognitiveservices/azure-cognitiveservices-vision-face/azure/cognitiveservices/vision/face/models/_models_py3.py - sdk/core/azure-core/tests/test_basic_transport.py - sdk/core/azure-servicemanagement-legacy/azure/servicemanagement/_http/winhttp.py - sdk/core/azure-servicemanagement-legacy/azure/servicemanagement/servicemanagementservice.py - sdk/cosmos/azure-cosmos/azure/cosmos/_synchronized_request.py - sdk/eventgrid/azure-eventgrid/azure/eventgrid/_policies.py - sdk/graphrbac/azure-graphrbac/azure/graphrbac/models/graph_error.py - sdk/graphrbac/azure-graphrbac/azure/graphrbac/models/graph_error_py3.py - sdk/loganalytics/azure-loganalytics/azure/loganalytics/models/error_response.py - sdk/loganalytics/azure-loganalytics/azure/loganalytics/models/error_response_py3.py - sdk/powerbiembedded/azure-mgmt-powerbiembedded/azure/mgmt/powerbiembedded/models/error.py - sdk/powerbiembedded/azure-mgmt-powerbiembedded/azure/mgmt/powerbiembedded/models/error_py3.py - sdk/search/azure-search-documents/azure/search/documents/_paging.py - sdk/search/azure-search-documents/azure/search/documents/aio/_paging.py - sdk/servermanager/azure-mgmt-servermanager/azure/mgmt/servermanager/models/error.py - sdk/servermanager/azure-mgmt-servermanager/azure/mgmt/servermanager/models/error_py3.py - sdk/servicefabric/azure-servicefabric/azure/servicefabric/models/_models.py - sdk/servicefabric/azure-servicefabric/azure/servicefabric/models/_models_py3.py - sdk/storage/azure-storage-blob/tests/test_retry.py - sdk/storage/azure-storage-blob/tests/test_retry_async.py Fixes: - Should read `responded` rather than `responsed`. - Should read `practical` rather than `pratical`. - Should read `coverage` rather than `covereage`. - Should read `transmission` rather than `transmition`. - Should read `response` rather than `resonse`. - Should read `request` rather than `resquest`. - Should read `hyphen` rather than `hypen`. - Should read `guaranteed` rather than `guaranted`. Closes #19126
Thank you for your contribution timgates42! We will review the pull request and get back to you soon. |
hey @timgates42 , thanks for the PR! |
Thanks @yunhaoling have update the PR |
/azp run python - graphrbac - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @timgates42 , thanks for the PR! LGTM
I double checked the files and found lots of them are auto-generated which means to completely fix the typo, we should fix them in the swagger file in the repo https://github.com/Azure/azure-rest-api-specs/tree/master/specification.
However, this doesn't stop us from merging the PR. We also welcome you to make PRs to azure-rest-api-spec repo. Thanks!
…into protocol_base * 'master' of https://github.com/Azure/azure-sdk-for-python: (229 commits) Sync eng/common directory with azure-sdk-tools for PR 1688 (#19272) update all ubuntu vmImage to 20.04 (#19227) add base class for feedback (#19265) Enable tests for integration samples (#18531) docs: fix a few simple typos (#19127) Increment package version after release of azure-eventgrid (#19197) Increment package version after release of azure-monitor-query (#19208) earliest versions of communication identity tests are set up improperly. skip 1.0.0 in regression testing (#19258) Run mypy in azure-keyvault-administration CI (#19246) [text analytics] change return type of analyze actions to list of list (#18994) Increment package version after release of azure-data-tables (#19192) suppress min number less than 14 (#19230) [Key Vault] Address administration feedback (#19099) [textanalytics] remove warning tests (#19217) [translation] enable samples to run in CI (#19190) update custom_granularity_value to be more than 300 (#19215) Increment package version after release of azure-security-attestation (#19212) Enabling Before/After Test Customization for Standard CI Pipelines (#19187) bump sphinx version to resolve the weird issue with the caption not getting the correct class (#19188) [AutoRelease] t2-agrifood-2021-06-09-15946 (#19174) ...
…into get_testserver_working * 'master' of https://github.com/Azure/azure-sdk-for-python: (55 commits) [AppConfig] mypy fixes (Azure#18858) [translation] renames (Azure#19285) [Key Vault] Update metadata for release (Azure#19286) [AppConfig] enable samples (Azure#18857) KeyVaultBackupOperation -> KeyVaultBackupResult (Azure#19284) renaming (Azure#19280) [Key Vault] Custom polling method for admin backup client (Azure#19204) [textanalytics] add ARM template + run samples in CI (Azure#19270) removed example from description (Azure#18781) [Key Vault] Update READMEs with RBAC information (Azure#19275) Sync eng/common directory with azure-sdk-tools for PR 1688 (Azure#19272) update all ubuntu vmImage to 20.04 (Azure#19227) add base class for feedback (Azure#19265) Enable tests for integration samples (Azure#18531) docs: fix a few simple typos (Azure#19127) Increment package version after release of azure-eventgrid (Azure#19197) Increment package version after release of azure-monitor-query (Azure#19208) earliest versions of communication identity tests are set up improperly. skip 1.0.0 in regression testing (Azure#19258) Run mypy in azure-keyvault-administration CI (Azure#19246) [text analytics] change return type of analyze actions to list of list (Azure#18994) ...
There are small typos in:
Fixes:
responded
rather thanresponsed
.practical
rather thanpratical
.coverage
rather thancovereage
.transmission
rather thantransmition
.response
rather thanresonse
.request
rather thanresquest
.hyphen
rather thanhypen
.guaranteed
rather thanguaranted
.Closes #19126