Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear environment variables before DefaultAzureCredential test #19106

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Jun 4, 2021

DefaultAzureCredential uses $AZURE_TENANT_ID as a default tenant for VisualStudioCodeCredential. #18846 was able to merge with a test that fails when that variable has a value because it doesn't have a value in CI. It has a value in the nightly live test run, however, so this PR unsets the variable at the start of the test. It also unsets AZURE_AUTHORITY_HOST to prevent a similar future problem when we start running live tests in sovereign clouds.

@chlowell chlowell requested review from mccoyp and schaabs as code owners June 4, 2021 16:43
@chlowell chlowell enabled auto-merge (squash) June 4, 2021 16:44
@chlowell chlowell merged commit 1ece552 into master Jun 4, 2021
@chlowell chlowell deleted the chlowell/vscode-test-fix branch June 4, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants