[Tables] changes to not allow strings for credentials #19095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annatisch
reviewed
Jun 4, 2021
| @@ -392,12 +393,9 @@ def format_query_string(sas_token, credential): | |||
| if sas_token and isinstance(credential, AzureSasCredential): | |||
| raise ValueError( | |||
| "You cannot use AzureSasCredential when the resource URI also contains a Shared Access Signature.") | |||
| if sas_token and not credential: | |||
| query_str += sas_token | |||
There was a problem hiding this comment.
We need to keep this first if statement I think. That's what preserves the URL SAS token
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
Jun 4, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Jun 2, 2022
Review request for Microsoft.ContainerService to add version 2022-05-02-preview (Azure#19262) * Adds base for updating Microsoft.ContainerService from version preview/2022-04-02-preview to version 2022-05-02-preview * Updates readme * Updates API version in new specs and examples * update readmes (Azure#19081) * add blob csi driver into 0502preview (Azure#19095) Co-authored-by: weizhichen <[email protected]> * Add read only field for `currentOrchestratorVersion` (Azure#19107) * currentOrchestratorVersion is read-only property * Only apply change to 2022-05-02-preview * Add keyVaultNetworkAccess and keyVaultResourceId into securityProfile.azureKeyVaultKms to support key vault with private link (Azure#19086) * Add keyVaultNetworkAccess and keyVaultResourceId into securityProfile.azureKeyVaultKms to support key vault with private link * fix * Add KEDA configuration options (Azure#19153) * 2022-05-02-preview defender updates (Azure#19172) * 2022-05-02-preview defender updates * update example * Typo * Update sample * typo * another typo Co-authored-by: weizhi <[email protected]> Co-authored-by: weizhichen <[email protected]> Co-authored-by: Thalia Wang <[email protected]> Co-authored-by: Bin Xia <[email protected]> Co-authored-by: Jatin Sanghvi <[email protected]> Co-authored-by: Or Parnes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.