[formrecognizer] regenerates on v2.1 #18551

kristapratico · 2021-05-06T19:44:30Z

Resolves #18133 #17062 #15276 #18482

Regenerates on v2.1 and sets as default. Note that AAD is not working yet.

kristapratico · 2021-05-11T03:56:09Z

/azp run python - formrecognizer - ci

azure-pipelines · 2021-05-11T03:56:28Z

Azure Pipelines successfully started running 1 pipeline(s).

kristapratico · 2021-05-11T15:24:23Z

/azp run python - formrecognizer - ci

azure-pipelines · 2021-05-11T15:24:46Z

Azure Pipelines successfully started running 1 pipeline(s).

...azure/ai/formrecognizer/_generated/v2_0/aio/operations/_form_recognizer_client_operations.py

danieljurek · 2021-05-11T17:16:36Z

/azp run python - formrecognizer - ci

azure-pipelines · 2021-05-11T17:16:57Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/formrecognizer/azure-ai-formrecognizer/tests/test_content_from_url_async.py

catalinaperalta · 2021-05-11T17:08:21Z

...r/azure-ai-formrecognizer/samples/async_samples/sample_recognize_identity_documents_async.py

                if country:
-                    print("Country: {} has confidence: {}".format(country.value, country.confidence))
+                    print("Country Region: {} has confidence: {}".format(country.value, country.confidence))


Do we need to add a slash here? Or join the words like the field name?

Not sure what you mean. Can you post an example?

I was wondering if Country Region should be Country/Region or CountryRegion? Simply because I skimmed through the docs shared from the service team and I know it is sensitive to how this information is shown.

Ok just checked the doc...I think we should go with Country/Region to make sure we're displaying the information correctly (this is the example I see the guidance following the most)

Honestly this feels like a nit to me 😅 but just said it since I'm not sure if the space implies something different than the slash...but I may be analyzing this too much.

sdk/formrecognizer/azure-ai-formrecognizer/tests/test_invoice.py

catalinaperalta

Only left my country region nit, but aside from that this looks great. Thanks for doing this!!

…into fix_confidentialledger_aiohttp * 'master' of https://github.com/Azure/azure-sdk-for-python: regenerate (Azure#18647) [formrecognizer] remove polling interval from doc comments (Azure#18645) [formrecognizer] regenerates on v2.1 (Azure#18551) adding images to anonymous client (Azure#18646) Confidential Ledger: Update README samples and CHANGELOG (Azure#18644) [Container Registry] Anonymous Access Client (Azure#18550)

[Hub Generated] Publish private branch 'dev-orbital-Microsoft.Orbital-2021-04-04-preview' (Azure#18551) * New Swagger Spec File * New Swagger Example Spec File * New Readme Config File * New Azure AZ Readme Config File * New Azure CLI Readme Config File * New Go Language Readme Config File * New Python Language Readme Config File * New Typescript Language Readme Config File * New C# Language Readme Config File * Orbital sdk 2021 04 04 preview (#5253) * New Readme Config File * New Go Language Readme Config File * New Typescript Language Readme Config File * New Python Language Readme Config File * New C# Language Readme Config File * New Ruby Language Readme Config File * New Swagger Spec File * New Swagger Example Spec File * Added orbital.json file * Passed linting using AutoRest for 2020-09-01 Azure Orbital Private Privew * Updated Operation object under Azure Orbital 2020-09-01 preview. * Updated Operation object under Azure Orbital 2020-09-01 preview. * Updated Satellites object for Azure Orbital 2020-09-01 preview * Updated examples for Azure Orbital Private Preview 2020-09-01 * Updated examples for Azure Orbital Private Preview 2020-09-01 * Updated examples for Azure Orbital Private Preview 2020-09-01 * Addressed feedback from ARMChangesRequested * Updated the GetAvailableContacts api to add long running operation * Updated the api version * Updated the objects based on discussion with PM. * list available ground station made a POST request (#2521) * list available ground station made a POST request * Swagger LintDiff fix Co-authored-by: Devanshu Singh <[email protected]> * swagger specs for version-20210404-preview * removed cross version references. Copied over unchanged examples from the previous API version 2021-09-01-preview * removed availableGroundStations API * New Readme Config File New Go Language Readme Config File New Typescript Language Readme Config File New Python Language Readme Config File New C# Language Readme Config File New Ruby Language Readme Config File New Swagger Spec File New Swagger Example Spec File Added orbital.json file Passed linting using AutoRest for 2020-09-01 Azure Orbital Private Privew Updated Operation object under Azure Orbital 2020-09-01 preview. Updated Operation object under Azure Orbital 2020-09-01 preview. Updated Satellites object for Azure Orbital 2020-09-01 preview Updated examples for Azure Orbital Private Preview 2020-09-01 Updated examples for Azure Orbital Private Preview 2020-09-01 Updated examples for Azure Orbital Private Preview 2020-09-01 Addressed feedback from ARMChangesRequested Updated the GetAvailableContacts api to add long running operation Updated the api version Updated the objects based on discussion with PM. list available ground station made a POST request (#2521) * list available ground station made a POST request * Swagger LintDiff fix Co-authored-by: Devanshu Singh <[email protected]> * validation check changes. Avocado, SpellCheck and prettier * validation checks changes * Modify readme.md for sdk generation * added system data * sdk pre namer validation changes * lintdiff warning changes * add comms scenario swagger (#3794) * add comms scenario swagger * remove unused example * fix some validation errors * fix style issues * update spec based on feedback * add updated example files * fix CI errors * change endpoints/connections list APIs to posts from gets * connections lists from endpoints return resource IDs rather than full objects. * update examples files for endpoints connections list APIs * fix operationIds and add descriptions * fix more op ids and add descriptions for real * fix typos, add constraints, and remove kbps/gbps from bandwidth (#4023) * Updates to Resource Types (Modifications and Renames) (#4294) * update orbital.json * update examples * prettier fix * unfix old api version * fix ci issues * make more fields immutable * update provisioning states * swagger specs for Available groundstation APIs, version 2021-preview (#4920) * swagger specs for Available groundstation APIs, version 2021-preview * npm prettier check * added type object * removed capability and global comms info from responses * prettier fix * changed AP id response * changes to schema to follow ARM format, resource id update * Spelling check fix * Ground Station spell check * added groundstation to custom words * Revert "added groundstation to custom words" This reverts commit 0d7e18217de98836dcb8ba991685e15436004836. * Revert "Ground Station spell check" This reverts commit ef85b3b26f9ddf81dc1f50a9b677f9d8f115c4cf. * Revert "Spelling check fix" This reverts commit 6bd95c6e013889b6d488703846bbe87bbbb9c494. * word addition * type in response * type definition in swagger * readonly add Co-authored-by: Akanksha Bhattacharyya <[email protected]> * removed comms APIs * readme updated * fixed Swagger Avocado errors * swagger lintDiff fix 1 * swagger lintDiff fix 2 * swagger lintDiff fix 3 Co-authored-by: Sunny Patel <[email protected]> Co-authored-by: Sunny Patel <[email protected]> Co-authored-by: Arthur Ning <[email protected]> Co-authored-by: Devanshu Singh <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Jim Harris <[email protected]> Co-authored-by: Akanksha Bhattacharyya <[email protected]> Co-authored-by: Akanksha Bhattacharyya <[email protected]> * operation IDs updated (#5461) Co-authored-by: Devanshu Singh <[email protected]> * Dev orbital microsoft.orbital 2021 04 04 preview (#5491) * operation IDs updated * updated OperationListResult definition * review points implemented Co-authored-by: Devanshu Singh <[email protected]> * Azure Orbital - Review points implemented (#5507) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * reorder some parameters Co-authored-by: Devanshu Singh <[email protected]> Co-authored-by: ArcturusZhang <[email protected]> * Removed Empty allOf (#5510) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * removed empty allOf * validation checks Co-authored-by: Devanshu Singh <[email protected]> * readme.go.md fixed (#5512) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * removed empty allOf * validation checks * readme.go.md fixed Co-authored-by: Devanshu Singh <[email protected]> * Remove last empty allOf (#5513) * operation IDs updated * updated OperationListResult definition * review points implemented * referencing CloudError, ApiVersionParameter, ResourceGroupNameParameter, SubscriptionIdParameter from common-types * reverting cloudError refs * prettify json * removed empty allOf * validation checks * readme.go.md fixed * remove one last empty allOf Co-authored-by: Devanshu Singh <[email protected]> * stable API version 2022-03-01 * valid json * lint diff fix * lint diff fix 2 * avocado fix * lint diff warninga 1 * lint diff warnings 2 * prettier fix * readme.me updated 2022-03-01 * Update readme.python.md Co-authored-by: Sunny Patel <[email protected]> Co-authored-by: Sunny Patel <[email protected]> Co-authored-by: Arthur Ning <[email protected]> Co-authored-by: Devanshu Singh <[email protected]> Co-authored-by: Zhenglai Zhang <[email protected]> Co-authored-by: Jim Harris <[email protected]> Co-authored-by: Akanksha Bhattacharyya <[email protected]> Co-authored-by: Akanksha Bhattacharyya <[email protected]> Co-authored-by: ArcturusZhang <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>

kristapratico added 2 commits May 6, 2021 12:35

add v2.1 generation

5d4e9fe

some fixes for v2.1

e661446

kristapratico added the Cognitive - Form Recognizer label May 6, 2021

kristapratico self-assigned this May 6, 2021

kristapratico mentioned this pull request May 6, 2021

[formrecognizer] regen on v2.1 #18244

Closed

kristapratico added 5 commits May 6, 2021 19:19

add note about 3.5 deprecation

355011c

ingest new changes

3625a09

adjust code for new field value types and remove the old

6185d84

adjustments to tests for changes in models

1d82f8b

update changelog and samples for CountryRegion

a4274b0

kristapratico mentioned this pull request May 9, 2021

[formrecognizer] Review feedback #18320

Closed

kristapratico added 3 commits May 8, 2021 23:13

api version compatibility

62ca67f

add recordings for v2.1

50da70f

merge master

254aa53

kristapratico marked this pull request as ready for review May 11, 2021 03:55

kristapratico requested review from catalinaperalta and iscai-msft as code owners May 11, 2021 03:55

catalinaperalta reviewed May 11, 2021

View reviewed changes

...azure/ai/formrecognizer/_generated/v2_0/aio/operations/_form_recognizer_client_operations.py Show resolved Hide resolved

Exclude recordings from spellcheck

7ef62ba

catalinaperalta reviewed May 11, 2021

View reviewed changes

kristapratico added 2 commits May 11, 2021 10:51

Merge branch 'master' into fr2.1

b9971e9

skip tests for regression in tables bounding box

9fb4110

catalinaperalta approved these changes May 11, 2021

View reviewed changes

review feedback + skip AAD tests since not deployed

d077fb5

kristapratico merged commit 9650c02 into master May 11, 2021

kristapratico deleted the fr2.1 branch May 11, 2021 22:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[formrecognizer] regenerates on v2.1 #18551

[formrecognizer] regenerates on v2.1 #18551

kristapratico commented May 6, 2021 •

edited

Loading

kristapratico commented May 11, 2021

azure-pipelines bot commented May 11, 2021

kristapratico commented May 11, 2021

azure-pipelines bot commented May 11, 2021

danieljurek commented May 11, 2021

azure-pipelines bot commented May 11, 2021

catalinaperalta May 11, 2021

kristapratico May 11, 2021

catalinaperalta May 11, 2021

catalinaperalta May 11, 2021 •

edited

Loading

catalinaperalta left a comment

[formrecognizer] regenerates on v2.1 #18551

[formrecognizer] regenerates on v2.1 #18551

Conversation

kristapratico commented May 6, 2021 • edited Loading

kristapratico commented May 11, 2021

azure-pipelines bot commented May 11, 2021

kristapratico commented May 11, 2021

azure-pipelines bot commented May 11, 2021

danieljurek commented May 11, 2021

azure-pipelines bot commented May 11, 2021

catalinaperalta May 11, 2021

Choose a reason for hiding this comment

kristapratico May 11, 2021

Choose a reason for hiding this comment

catalinaperalta May 11, 2021

Choose a reason for hiding this comment

catalinaperalta May 11, 2021 • edited Loading

Choose a reason for hiding this comment

catalinaperalta left a comment

Choose a reason for hiding this comment

kristapratico commented May 6, 2021 •

edited

Loading

catalinaperalta May 11, 2021 •

edited

Loading