Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Identity] Fix unused import error #18362

Merged
merged 1 commit into from
Apr 27, 2021
Merged

[Identity] Fix unused import error #18362

merged 1 commit into from
Apr 27, 2021

Conversation

mccoyp
Copy link
Member

@mccoyp mccoyp commented Apr 27, 2021

See this recent pylint error.

@mccoyp mccoyp added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Apr 27, 2021
@mccoyp mccoyp requested review from chlowell and schaabs as code owners April 27, 2021 19:01
chlowell
chlowell approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I wonder how it slipped past the goalie, we run pylint in CI 🤔

@mccoyp
Copy link
Member Author

mccoyp commented Apr 27, 2021

Yeah, it seems to have just started getting flagged a few days ago (first noticed it on an unrelated PR from Sean). I couldn't track down a change here or elsewhere that explains it 😶

@mccoyp mccoyp merged commit 6ad43ad into Azure:master Apr 27, 2021
@mccoyp mccoyp deleted the identity-fix branch April 27, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlowell chlowell chlowell approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccoyp @chlowell