Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] add testcases for labeled tables - fixed/variable rows #18214

Merged
merged 4 commits into from
Apr 22, 2021
Merged

[formrecognizer] add testcases for labeled tables - fixed/variable rows #18214

merged 4 commits into from
Apr 22, 2021

Conversation

kristapratico
Copy link
Member

No description provided.

@kristapratico kristapratico self-assigned this Apr 22, 2021
@kristapratico kristapratico marked this pull request as ready for review April 22, 2021 17:49
catalinaperalta
catalinaperalta approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My only nit would be that formrecognizer_label_table_variable_rows_storage_container_sas_url is super long, but I dont see how to shorten it unless we use shorter versions of the words themselves. It's still fine if you merge it as is though.

@kristapratico
Copy link
Member Author

LGTM! My only nit would be that formrecognizer_label_table_variable_rows_storage_container_sas_url is super long, but I dont see how to shorten it unless we use shorter versions of the words themselves. It's still fine if you merge it as is though.

I could drop the "label" and "storage" part? formrecognizer_table_variable_rows_container_sas_url

@catalinaperalta
Copy link
Member

catalinaperalta commented Apr 22, 2021 •
edited
Loading

I could drop the "label" and "storage" part? formrecognizer_table_variable_rows_container_sas_url

Yeah that works for me! The name still seems pretty clear to me without those words. I like it 👍

maririos
maririos approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kristapratico kristapratico merged commit e135c69 into Azure:master Apr 22, 2021
@kristapratico kristapratico deleted the labeled-tables-tests branch April 22, 2021 23:11
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Apr 23, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
52d0341 
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [Tables] hot fix for pipelines (Azure#18273)
  [Tables] Updates for apiview & sphinx docs (Azure#18134)
  override purview deps in shared reqs (Azure#18270)
  [Service Bus] fix deadletter sample + update README (Azure#18261)
  Update credential docstrings (Azure#18205)
  Refactor ImdsCredential to use ManagedIdentityClient (Azure#18120)
  [Key Vault] Target multiple API versions with tests (keys) (Azure#18149)
  Initial ModelsRepositoryClient (Azure#17180)
  [Communication]: Enabled Phone Number Search Test (Azure#18247)
  [Key Vault] Update default MHSM location for tests
  Update identity migration guide (Azure#18239)
  [AutoRelease] t2-managedservices-2021-04-22-08436(wave4) (Azure#18224)
  [AutoRelease] t2-hybridnetwork-2021-04-20-93742 (Azure#18169)
  Add Key Vault cert suppression (Azure#18245)
  update to aab1fb9 (Azure#18246)
  Enable retain runs. (Azure#18200)
  [formrecognizer] add testcases for labeled tables - fixed/variable rows (Azure#18214)
  Add caching support to verify-links (Azure#18231)
  add reading order for logging (Azure#18233)
  [purview] allow purview pylint failures (Azure#18237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@maririos maririos maririos approved these changes

@catalinaperalta catalinaperalta catalinaperalta approved these changes

@witemple-msft witemple-msft Awaiting requested review from witemple-msft

@mssfang mssfang Awaiting requested review from mssfang

Assignees

@kristapratico kristapratico

Labels
Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kristapratico @catalinaperalta @maririos @iscai-msft