[translation] unredact headers and query params for logging #18117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maririos
reviewed
Apr 19, 2021
| self._client = _BatchDocumentTranslationClient( | ||
| endpoint=endpoint, | ||
| credential=credential, # type: ignore | ||
| api_version=self._api_version, | ||
| sdk_moniker=USER_AGENT, | ||
| authentication_policy=authentication_policy, | ||
| http_logging_policy=get_http_logging_policy(), |
There was a problem hiding this comment.
asking as I don't know how this works on Python... if the service introduces new headers/query parameters, this needs to be updated? or will the user be able to add more logging policies if they desire? -> it might not be needed if the list is always updated though
There was a problem hiding this comment.
There is a list of allowed headers in the policy, but it's general and doesn't include service-specific headers or query params. It can always be updated if the service starts sending anything new.
maririos
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17954
Makes sure we do not redact non-sensitive information that could be helpful when debugging.