fixing broken links #17278
fixing broken links #17278
Conversation
seankane-msft
requested review from
annatisch,
chlowell,
lmazuel,
mccoyp,
rakshith91,
schaabs,
swathipil,
xiangyan99 and
yunhaoling
as code owners
ghost
added
|
I remember maybe we should check with the EngSys team to see why |
|
/azp run python - aggregate-reports |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
| @@ -27,7 +27,7 @@ To try and improve the development experience across Azure services, a set of un | |||
|
|
|||
| ### Cross Service SDK improvements | |||
|
|
|||
| The modern Key Vault client library also provides the ability to share in some of the cross-service improvements made to the Azure development experience, such as | |||
| The modern Key Vault client library also provides the ability to share in some of the cross-service improvements made to the Azure development experience, such as | |||
There was a problem hiding this comment.
I updated these links yesterday but didn't realize that everyone had the same issue -- on line 26 I used https://azure.github.io/azure-sdk/general_introduction.html, but that can be replaced with https://azure.github.io/azure-sdk/python/guidelines/index.html. (This goes for keys and secrets as well)
There was a problem hiding this comment.
Adding this change
ghost
merged commit 
|
Looks like this PR caused a CI failure, could you investigate @seankane-msft: |
@mitchdenny The failure is a test in Python 2.7, I don't believe it has to do with the changed links here. |
Cdn swagger 2021 06 01 fix (Azure#17278) * Add blockchain to latest profile * Add additional types * [CDN] Fix incorrect type for compressionSettings and SharedPrivateLinkResourceProperties * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Update SecurityPolicy patch operation * Removing originResponseTimeoutSeconds from endpoint level * Fix the afdendpoint example * Fix the cacheDuration format * Adding user assigned identity to managed identity * Fix the typo and example * Fix OBJECT_ADDITIONAL_PROPERTIES * Revert responseBasedAFDOriginErrorDetectionSettings Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: Chenglong Liu <[email protected]> Co-authored-by: Bo Zhang <[email protected]> Co-authored-by: SINADELL <SINADELL@SINADELL-DEV7> Co-authored-by: Sindhuri <[email protected]> Co-authored-by: AJ Brown <[email protected]>
Fixing broken links found by the python - aggregate - reports pipeline