Update get_package_properties.py logic for python 2.7 #17144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
requested review from
danieljurek,
mitchdenny,
scbedd and
weshaggard
as code owners
weshaggard
reviewed
Mar 8, 2021
| @@ -11,6 +11,8 @@ | |||
| parser.add_argument('-s', '--search_path', required=True, help='The scope of the search') | |||
| args = parser.parse_args() | |||
|
|
|||
| for p in glob.glob(args.search_path, recursive=True): | |||
There was a problem hiding this comment.
What about this doesn't work for python 2.7?
There was a problem hiding this comment.
Also why do we care about 2.7 support in this script? Is there a case we are running in that context?
There was a problem hiding this comment.
glob.glob( ,recursive=True) does not work in python 2.7. This causes it to fail when it is run on some test pipelines that are using python 2.7
weshaggard
approved these changes
Mar 8, 2021
|
/check-enforcer override |
iscai-msft
added a commit
that referenced
this pull request
Mar 8, 2021
…into update_ta_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: Update get_package_properties.py logic for python 2.7 (#17144) update changelog (#17150) [ServiceBus] 7.1.0 Release update changelog (#17135) [ServiceBus] Object mapping support (#17080) move SetTestPipeline into its own template (#17141) Revise token cache configuration API (#16326) Fix dup cloud error (#17097) Perf tests for monitor exporter (#17067) [Communication] - Phone Number - Redesigned API (#16671) disable retry (#17078) [Key Vault] Add perf tests for certificates, keys, and secrets (#17073) [text analytics] Analyze updates for v5.1.0b6 (#17003) Add any additional claims to AuthenticationRequiredError (#17136) Fix logic in SetTestPipelineVersionInEngCommon (#17138) [Key Vault] Make test resource cleanup script asynchronous (#17032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
eng/scripts/get_package_properties.pylogic to enable it work for python 2.7