samples hero scenarios #16936

mshaban-msft · 2021-02-25T16:38:21Z

No description provided.

check-enforcer · 2021-02-25T16:43:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

mshaban-msft · 2021-02-25T17:00:05Z

@kristapratico

kristapratico

Minor things, looks good :)

Comments in first sample generally apply to all files

...slation/azure-ai-documenttranslation/samples/async_samples/sample_batch_translation_async.py

...-ai-documenttranslation/samples/async_samples/sample_batch_translation_with_storage_async.py

...ranslation/azure-ai-documenttranslation/samples/async_samples/sample_check_statuses_async.py

...n/azure-ai-documenttranslation/samples/async_samples/sample_list_all_submitted_jobs_async.py

...slation/azure-ai-documenttranslation/samples/async_samples/sample_batch_translation_async.py

...ranslation/azure-ai-documenttranslation/samples/async_samples/sample_check_statuses_async.py

…c Client

kristapratico · 2021-03-03T16:42:24Z

looks good, going to merge it

* initial commit * update samples * updates from feedback * johans feedback * renaming to use job terminology * update samples - optional src language * samples hero scenarios (#16936) * [samples] added 'batch_translation_async' sample * [samples] added 'batch_translation_with_storage_async' sample * [samples] added remianing async samples * [samples] update file names * [samples] added self to instance methods * [samples][async] fix import textanalytics :) * [samples] fix self. when calling instance methods * [samples] fixed async check status to use AsyncItemPaged used in Async Client * [samples] async -> some async operations instead of sync ones * [samples][async] use async blob operations * [samples][async] blob download async * [samples][async] check_documents async * [samples][async] added some missing await methods * [async samples] change await time to recommended period * [samples] updated async samples to comply with new changes * remove 3.5 support Co-authored-by: Mohamed Shaban <[email protected]>

* [samples] added 'batch_translation_async' sample * [samples] added 'batch_translation_with_storage_async' sample * [samples] added remianing async samples * [samples] update file names * [samples] added self to instance methods * [samples][async] fix import textanalytics :) * [samples] fix self. when calling instance methods * [samples] fixed async check status to use AsyncItemPaged used in Async Client * [samples] async -> some async operations instead of sync ones * [samples][async] use async blob operations * [samples][async] blob download async * [samples][async] check_documents async * [samples][async] added some missing await methods * [async samples] change await time to recommended period * [samples] updated async samples to comply with new changes

* initial commit * update samples * updates from feedback * johans feedback * renaming to use job terminology * update samples - optional src language * samples hero scenarios (#16936) * [samples] added 'batch_translation_async' sample * [samples] added 'batch_translation_with_storage_async' sample * [samples] added remianing async samples * [samples] update file names * [samples] added self to instance methods * [samples][async] fix import textanalytics :) * [samples] fix self. when calling instance methods * [samples] fixed async check status to use AsyncItemPaged used in Async Client * [samples] async -> some async operations instead of sync ones * [samples][async] use async blob operations * [samples][async] blob download async * [samples][async] check_documents async * [samples][async] added some missing await methods * [async samples] change await time to recommended period * [samples] updated async samples to comply with new changes * [client] modify the 'create_translation_job()' method * [models wrapping 'JobStatusDetail' * [models wrapping] update client * [models wrapping] formats mapping [documents, glossaries, storage] * [models wrapping] batch document input * [models wrapping] added document status * [models wrapping] added support for list document status * [models wrapping] remove unwanted code * [models wrapping] forgot to add job id * [model wrapping] list all jobs * [pr review] extract job id * [refactor] some refactoring * [pr reviews] refactor * [refactor] to_generated in glossary * [refactor] to generated in StorageTargets * [refactor] to_generated in BatchDocumentInput * [refactor] to_generated in Glossary more * [refactor] make code readable -> storage formats * [integration] added support for wait_until_done * [refactor] spelling error * [integrate sdk] updated "wait_until_done" to use azure core poller instead of busy wait * [sync client][wait till done] initial poller * [sync client][wait poller] poller algorithm completed * [PR comments] wrap model before returning * [pr reviews] adjust parameter type to list * [pr reviews] some linter checks * [pr reviews] remove static methods, and fix private naming convention in model functions * [pr reviews] fix return type value * [PR reviews] implement unimplemented inherited abstract method * [pr reviews] fix python private method naming in client * [pr review] handle case with no error happening * [pr reviews] renaming stuff :) * [pr reviews] renaming more stuff :) * [pr reviews] refactor private functions and linting options * [bug fix] poller -> handle non-standard status responses * [#17289] remove supported storage sources method * [bug fix] private method name * [linting] _models.py * [linting] client * [linting] models * [bug fix] wait until done pipeline response * [linting] more client linting * [linting] more client * [linting] more in models * more linting * [linting] more linting things * [linting] client * [linting] more * [linting] more * [linting] for goodness sakes! * [bug fix] models -> StorageTarget -> handle when user doesn't pass glossaries * [linting] line-too-long Co-authored-by: Krista Pratico <[email protected]>

* initial commit * update samples * updates from feedback * johans feedback * renaming to use job terminology * update samples - optional src language * samples hero scenarios (#16936) * [samples] added 'batch_translation_async' sample * [samples] added 'batch_translation_with_storage_async' sample * [samples] added remianing async samples * [samples] update file names * [samples] added self to instance methods * [samples][async] fix import textanalytics :) * [samples] fix self. when calling instance methods * [samples] fixed async check status to use AsyncItemPaged used in Async Client * [samples] async -> some async operations instead of sync ones * [samples][async] use async blob operations * [samples][async] blob download async * [samples][async] check_documents async * [samples][async] added some missing await methods * [async samples] change await time to recommended period * [samples] updated async samples to comply with new changes * [client] modify the 'create_translation_job()' method * [models wrapping 'JobStatusDetail' * [models wrapping] update client * [models wrapping] formats mapping [documents, glossaries, storage] * [models wrapping] batch document input * [models wrapping] added document status * [models wrapping] added support for list document status * [models wrapping] remove unwanted code * [models wrapping] forgot to add job id * [model wrapping] list all jobs * [pr review] extract job id * [refactor] some refactoring * [pr reviews] refactor * [refactor] to_generated in glossary * [refactor] to generated in StorageTargets * [refactor] to_generated in BatchDocumentInput * [refactor] to_generated in Glossary more * [refactor] make code readable -> storage formats * [integration] added support for wait_until_done * [refactor] spelling error * [integrate sdk] updated "wait_until_done" to use azure core poller instead of busy wait * [sync client][wait till done] initial poller * [sync client][wait poller] poller algorithm completed * [PR comments] wrap model before returning * [pr reviews] adjust parameter type to list * [pr reviews] some linter checks * [pr reviews] remove static methods, and fix private naming convention in model functions * [pr reviews] fix return type value * [PR reviews] implement unimplemented inherited abstract method * [pr reviews] fix python private method naming in client * [pr review] handle case with no error happening * [pr reviews] renaming stuff :) * [pr reviews] renaming more stuff :) * [pr reviews] refactor private functions and linting options * [bug fix] poller -> handle non-standard status responses * [#17289] remove supported storage sources method * [bug fix] private method name * [linting] _models.py * [linting] client * [linting] models * [bug fix] wait until done pipeline response * [linting] more client linting * [linting] more client * [linting] more in models * more linting * [linting] more linting things * [linting] client * [linting] more * [linting] more * [linting] for goodness sakes! * [bug fix] models -> StorageTarget -> handle when user doesn't pass glossaries * [linting] line-too-long * [async client] submit translation job * [async client] job status * [async client] more function support added * [async client] added document status * [async client] add remaining methods * [async client] use async poller * [linting] asycn client * [linting] more Co-authored-by: Krista Pratico <[email protected]>

Adding additional fields to CallRecording File Status Udpated event (Azure#16936) * Adding additional fields to CallRecording File Status Udpated event * Updating the Recording event fields to enum * Updating the example for RecordingFileStatusUpdated event * Updating the recordingFormatType in recordingFileStatusUpdated example

mshaban-msft requested review from lmazuel and mayurid as code owners February 25, 2021 16:38

kristapratico reviewed Feb 25, 2021

View reviewed changes

kristapratico approved these changes Mar 2, 2021

View reviewed changes

...slation/azure-ai-documenttranslation/samples/async_samples/sample_batch_translation_async.py Outdated Show resolved Hide resolved

...ranslation/azure-ai-documenttranslation/samples/async_samples/sample_check_statuses_async.py Outdated Show resolved Hide resolved

MIDDLEEAST\v-moshaban added 13 commits March 2, 2021 18:59

[samples] added 'batch_translation_async' sample

44fafd8

[samples] added 'batch_translation_with_storage_async' sample

07500d5

[samples] added remianing async samples

7cf18ed

[samples] update file names

7c9b010

[samples] added self to instance methods

390966d

[samples][async] fix import textanalytics :)

ca1610f

[samples] fix self. when calling instance methods

ec4a922

[samples] fixed async check status to use AsyncItemPaged used in Asyn…

262915f

…c Client

[samples] async -> some async operations instead of sync ones

7f9c650

[samples][async] use async blob operations

df8fad8

[samples][async] blob download async

b6e0528

[samples][async] check_documents async

ab32fba

[samples][async] added some missing await methods

8a6c5b1

mshaban-msft force-pushed the v-moshaban/16712/samples_hero_scenarios branch from 202e168 to 8a6c5b1 Compare March 2, 2021 17:00

MIDDLEEAST\v-moshaban added 2 commits March 3, 2021 15:52

[async samples] change await time to recommended period

78ffc51

[samples] updated async samples to comply with new changes

26d3d50

kristapratico merged commit 28aabfb into Azure:document-translation Mar 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples hero scenarios #16936

samples hero scenarios #16936

mshaban-msft commented Feb 25, 2021

check-enforcer bot commented Feb 25, 2021

mshaban-msft commented Feb 25, 2021

kristapratico left a comment

kristapratico commented Mar 3, 2021

samples hero scenarios #16936

samples hero scenarios #16936

Conversation

mshaban-msft commented Feb 25, 2021

check-enforcer bot commented Feb 25, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

mshaban-msft commented Feb 25, 2021

kristapratico left a comment

Choose a reason for hiding this comment

kristapratico commented Mar 3, 2021