Added the Azure.MixedReality.Authentication library #16714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
added 28 commits
February 12, 2021 11:14
Shared no longer contains a `__init__.py` file to prevent cyclic dependencies.
- Lots of bugs around the async stuff. We actually need async versions of all of the credential types :(. You also have to use the async version of the bearer token policy, which took me a while to figure out.
This reverts commit a2e77f4.
- The swagger config file named as README gets picked up by some validation with certain assumptions, so I've renamed it.
- The version number now matches the other libraries.
craigktreasure
force-pushed
the
craig/mr-authentication-lib
branch
from
47b5fab to
9d0a681
Compare
sdk/mixedreality/azure-mixedreality-authentication/azure/mixedreality/authentication/_client.py
Outdated
Show resolved
Hide resolved
...ication/azure/mixedreality/authentication/_shared/aio/mixedreality_account_key_credential.py
Show resolved
Hide resolved
added 6 commits
February 16, 2021 10:33
rikogeln
reviewed
Feb 18, 2021
...thentication/azure/mixedreality/authentication/_shared/aio/mixed_reality_token_credential.py
Outdated
Show resolved
Hide resolved
craigktreasure
requested review from
danieljurek,
lmazuel,
mayurid,
mitchdenny,
scbedd and
weshaggard
as code owners
annatisch
reviewed
Feb 21, 2021
...mixedreality/azure-mixedreality-authentication/azure/mixedreality/authentication/__init__.py
Show resolved
Hide resolved
sdk/mixedreality/azure-mixedreality-authentication/azure/mixedreality/authentication/_client.py
Show resolved
Hide resolved
...ity/azure-mixedreality-authentication/azure/mixedreality/authentication/aio/_client_async.py
Show resolved
Hide resolved
tjprescott
reviewed
Feb 22, 2021
...ication/azure/mixedreality/authentication/_shared/aio/mixedreality_account_key_credential.py
Show resolved
Hide resolved
sdk/mixedreality/azure-mixedreality-authentication/azure/mixedreality/authentication/_utils.py
Outdated
Show resolved
Hide resolved
sdk/mixedreality/azure-mixedreality-authentication/azure/mixedreality/authentication/_utils.py
Outdated
Show resolved
Hide resolved
craigktreasure
force-pushed
the
craig/mr-authentication-lib
branch
from
3be2d57 to
e2d0f64
Compare
annatisch
approved these changes
Feb 23, 2021
|
Hello @craigktreasure! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an authentication library for Mixed Reality services, which all currently utilize a custom STS for authentication. Upcoming Mixed Reality client libraries will depend on this library to perform authentication using identities from Azure.Identity. See the added README.md for more information about the library.
ApiView link