Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt new MSAL auth code flow API #16449

Merged
merged 7 commits into from
Feb 4, 2021
Merged

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Feb 1, 2021

This closes #16429 by adopting msal 1.7.0's new authorization code API in InteractiveBrowserCredential. In addition to silencing deprecation warnings, this adds PKCE to the credential. One disadvantage is that the credential must now be tested manually because mock testing would require elaborate, fragile monkeypatching to work around security features of msal's implementation.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels Feb 1, 2021
@chlowell chlowell merged commit db4892a into Azure:master Feb 4, 2021
@chlowell chlowell deleted the msal-authcode branch February 4, 2021 16:59
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 4, 2021
…into analyze_redesign

* 'master' of https://github.com/Azure/azure-sdk-for-python: (32 commits)
  Adopt new MSAL auth code flow API (Azure#16449)
  [formrecognizer] use ARM template for tests (Azure#16432)
  T2 kusto 2021 02 04 (Azure#16527)
  T2 applicationinsights 2021 02 04 (Azure#16525)
  Sync eng/common directory with azure-sdk-tools for PR 1366 (Azure#16506)
  [Python] python track2 new pipeline fix (Azure#16494)
  Added package properties SDKType and NewSDK (Azure#16476)
  bump six dependencies in some libraries (Azure#16496)
  call on_error if timeout in flush (Azure#16485)
  Sync eng/common directory with azure-sdk-tools for PR 1365 (Azure#16505)
  Fix min dependency tests - update azure core (Azure#16504)
  Sync eng/common directory with azure-sdk-tools for PR 1364 (Azure#16503)
  Ma arch feedback (Azure#16502)
  Adding a new limitation to the README file. (Azure#16475)
  [Blob][Datalake] STG76 Preview (Azure#16349)
  append code coverage over each other (Azure#16202)
  Arch preview feedback (Azure#16441)
  Support CAE in azure-identity (Azure#16323)
  [EventHubs] Support for Custom endpoint adddress and custom certificate  (Azure#16295)
  [Communication] - Phone Number Management - Added support for AAD auth (Azure#16075)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Nov 10, 2021
Add qualityForRecognition attribute to Face Detection (Azure#16449)

* Add qualityForRecognition attribute to Face Detection

* Add a line for recognition model restriction

* Fix typo

* Add definitions for generation

Co-authored-by: Yang Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msal deprecation warnings when using InteractiveBrowserCredential
2 participants