[ServiceBus] Pre-GA Bug Bash fixes #15489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
KieranBrantnerMagee
commented
Nov 20, 2020
KieranBrantnerMagee
commented
- Small fix found during bug bash, an already disposed handler during iter finalizer causes issues on iter termination.
- Given the risks the above exposed, made the explicit getter which necessitated the iter wrapper voodoo internal so as to give time to ensure we're not locking ourselves into a dangerous pattern. This was simply a helper and the same functionality can still be accessed by iterating on the base receiver.
- Adjusts docs, samples, tests.
- Clarify one changelog point (Thanks for noting Yunhaoling)
- Fixes up some stress tests that had been missed in prior refactors and ensure all green.
… iter finalizer causes issues on iter termination. - Given the risks the above exposed, made the explicit getter which necessitated the iter wrapper voodoo internal so as to give time to ensure we're not locking ourselves into a dangerous pattern. This was simply a helper and the same functionality can still be accessed by iterating on the base receiver. - Adjusts docs, samples, tests. - clarify one changelog point (Thanks for noting Yunhaoling) - Fixes up some stress tests that had been missed in prior refactors and ensure all green.
KieranBrantnerMagee
added
Service Bus
Client
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
reviewed
Nov 20, 2020
yunhaoling
reviewed
Nov 20, 2020
sdk/servicebus/azure-servicebus/tests/stress_tests/test_stress_queues.py
Show resolved
Hide resolved
|
LGTM |
yunhaoling
previously approved these changes
Nov 20, 2020
Clarify changelog, add note to stress test purpose. Co-authored-by: Adam Ling (MSFT) <[email protected]>
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
previously approved these changes
Nov 21, 2020
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
approved these changes
Nov 21, 2020
|
/azp run python - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakshith91
approved these changes
Nov 21, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Sep 9, 2021
Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (Azure#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <[email protected]> * update readme for 2021-08-01 sdk generation (Azure#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <[email protected]> * allow disabling of runcommand (Azure#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (Azure#15564) Co-authored-by: Li Ma <[email protected]> * Add CreationData property to Agentpool level in 2021-08-01 API (Azure#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <[email protected]> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (Azure#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (Azure#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <[email protected]> * fix tag typo to match tag convention (Azure#15683) * add workload runtime to agent pool api (Azure#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (Azure#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * fix typo in readme.python.md (Azure#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <[email protected]> * merge recent custom-words.txt changes from main branch to resolve conflicts (Azure#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <[email protected]> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]>
msyyc
pushed a commit
that referenced
this pull request
Sep 10, 2021
* CodeGen from PR 15954 in Azure/azure-rest-api-specs Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <[email protected]> * update readme for 2021-08-01 sdk generation (#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <[email protected]> * allow disabling of runcommand (#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (#15564) Co-authored-by: Li Ma <[email protected]> * Add CreationData property to Agentpool level in 2021-08-01 API (#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <[email protected]> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <[email protected]> * fix tag typo to match tag convention (#15683) * add workload runtime to agent pool api (#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * fix typo in readme.python.md (#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <[email protected]> * merge recent custom-words.txt changes from main branch to resolve conflicts (#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <[email protected]> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
zihzhan-msft
added a commit
that referenced
this pull request
Sep 10, 2021
commit b2bdfe6 Author: Travis Prescott <[email protected]> Date: Fri Sep 10 11:48:44 2021 -0700 [Search] Regenerate with latest autorest (#20597) * Regenerate with latest autorest. * Bump azure.core dependency to resolve CI issues. commit 53ea0c0 Author: Jiefeng Chen <[email protected]> Date: Fri Sep 10 16:30:02 2021 +0800 Add auto-close and auto-run-pipline (#20516) * release_iseus_status_auto_reply * issue_aoto_close_revert * Update main.py * Update main.py * Update update_issue_body.py * Update reply_generator.py * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update update_issue_body.py * Update update_issue_body.py * Update main.py * Update reply_generator.py * Update main.py * Update update_issue_body.py * Update main.py * Update scripts/release_issue_status/update_issue_body.py * Update update_issue_body.py * Update main.py * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update scripts/release_issue_status/main.py * Update main.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/update_issue_body.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/update_issue_body.py * Update reply_generator.py * Update main.py * Update scripts/release_issue_status/update_issue_body.py Co-authored-by: msyyc <[email protected]> * Update scripts/release_issue_status/update_issue_body.py Co-authored-by: msyyc <[email protected]> * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update main.py * Update update_issue_body.py * Update main.py * Update scripts/release_issue_status/main.py * Update main.py * Update reply_generator.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update update_issue_body.py * Update main.py * Update update_issue_body.py * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update update_issue_body.py * Update update_issue_body.py * Update update_issue_body.py * Update update_issue_body.py * Update update_issue_body.py * Update main.py * Update main.py * Update release_issue_status.yml for Azure Pipelines * Update main.py * Update reply_generator.py * Add files via upload * Update reply_generator.py * Update update_issue_body.py * Update reply_generator.py * Update auto_pipeline_run.py * Update auto_pipeline_run.py * add auto-close * Update release_issue_status.yml for Azure Pipelines * Update auto_close.py * Update main.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * fix bug * Update main.py * Update auto_close.py * Update auto_close.py * Update main.py * Update reply_generator.py * Update main.py * Update main.py * Update auto_close.py * Update main.py * Update auto-close * Update auto_pipeline_run.py * Update update_issue_body.py * Update auto_pipeline_run.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * Update auto_pipeline_run.py * Add pipeline link * Update pipeline link * Update auto_pipeline_run.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * Update requirement.txt * Update auto_pipeline_run.py * Add get_python_pipeline * Update auto_pipeline_run.py * test * test * add outputfolder * add label * Update main.py * Update get_python_pipeline.py * Update main.py * Update auto_pipeline_run.py Co-authored-by: Zed <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: msyyc <[email protected]> commit acfb309 Author: Azure CLI Bot <[email protected]> Date: Fri Sep 10 11:28:30 2021 +0800 [AutoRelease] t2-containerservice-2021-09-09-17236 (#20614) * CodeGen from PR 15954 in Azure/azure-rest-api-specs Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <[email protected]> * update readme for 2021-08-01 sdk generation (#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <[email protected]> * allow disabling of runcommand (#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (#15564) Co-authored-by: Li Ma <[email protected]> * Add CreationData property to Agentpool level in 2021-08-01 API (#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <[email protected]> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <[email protected]> * fix tag typo to match tag convention (#15683) * add workload runtime to agent pool api (#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * fix typo in readme.python.md (#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <[email protected]> * merge recent custom-words.txt changes from main branch to resolve conflicts (#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <[email protected]> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 05aec3d Author: McCoy Patiño <[email protected]> Date: Thu Sep 9 18:41:31 2021 -0700 Redact account keys in recordings (#20537) commit 6a9cb86 Author: Xiang Yan <[email protected]> Date: Thu Sep 9 18:30:08 2021 -0700 Update to latest swagger (#20642) commit cd459a7 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 17:21:31 2021 -0700 Increment version for keyvault releases (#20638) Increment package version after release of azure-keyvault-administration commit bd89c09 Author: luc <[email protected]> Date: Thu Sep 9 17:09:01 2021 -0700 Update Communication Chat Swagger & Tests Record (#20578) * update swagger * update changelog commit 71871eb Author: Rakshith Bhyravabhotla <[email protected]> Date: Thu Sep 9 15:41:35 2021 -0700 Update CHANGELOG.md (#20631) commit 28bb632 Author: swathipil <[email protected]> Date: Thu Sep 9 15:35:48 2021 -0700 [SchemaRegistry] update Avro version + changelog (#20624) fixes: #20606 commit 3d29229 Author: Leighton Chen <[email protected]> Date: Thu Sep 9 15:06:15 2021 -0700 rpc (#20563) commit 5c1cf92 Author: Rakshith Bhyravabhotla <[email protected]> Date: Thu Sep 9 14:32:22 2021 -0700 Prepare for release (#20627) commit 43a17d2 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 14:01:18 2021 -0700 Install az module if not installed in deploy-stress-tests.ps1 (#20605) Co-authored-by: Ben Broderick Phillips <[email protected]> commit 6d34b90 Author: Yalin Li <[email protected]> Date: Thu Sep 9 13:36:32 2021 -0700 Address incorrect links in README.md (#20626) commit 0c0b975 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 13:34:52 2021 -0700 Increment version for keyvault releases (#20625) Increment package version after release of azure-keyvault-keys commit 0e5e53d Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 11:03:54 2021 -0700 Explicitly exit 0 so a failed inner command (like mvn) doesn't propagate up to a failure of the pipeline (#20609) Co-authored-by: Daniel Jurek <[email protected]> commit 476acd5 Author: McCoy Patiño <[email protected]> Date: Thu Sep 9 11:02:40 2021 -0700 [Identity] Resolve CredScan warnings (#20543) commit 853db90 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 10:59:29 2021 -0700 Increment version for identity releases (#20620) Increment package version after release of azure-identity commit 92a676d Author: Xiang Yan <[email protected]> Date: Thu Sep 9 09:15:26 2021 -0700 update changelog (#20619) commit 7373db2 Author: Yalin Li <[email protected]> Date: Wed Sep 8 18:49:45 2021 -0700 Run mypy in azure-keyvault-keys CI (#20545) commit 51f09fa Author: McCoy Patiño <[email protected]> Date: Wed Sep 8 18:21:08 2021 -0700 [Key Vault] Update changelogs for release (#20607) commit bad587d Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 17:28:20 2021 -0700 Sync eng/common directory with azure-sdk-tools repository (#20604) commit 1f2218a Author: swathipil <[email protected]> Date: Wed Sep 8 17:13:33 2021 -0700 [SchemaRegistry] update API for consistency (#20538) * changes * updated failing tests * keep Dict for now * pylint errors * nit * add recordings * tests recordings commit 40c9060 Author: Xiang Yan <[email protected]> Date: Wed Sep 8 16:01:33 2021 -0700 update release date (#20601) commit c11e835 Author: Xiang Yan <[email protected]> Date: Wed Sep 8 15:29:40 2021 -0700 add interactive_browser_client_id (#20591) * add interactive_browser_client_id * Update sdk/identity/azure-identity/azure/identity/_credentials/default.py Co-authored-by: Charles Lowell <[email protected]> * Update sdk/identity/azure-identity/azure/identity/_credentials/default.py Co-authored-by: Charles Lowell <[email protected]> * update * update * update * update * update * Update sdk/identity/azure-identity/azure/identity/_credentials/default.py Co-authored-by: McCoy Patiño <[email protected]> * update Co-authored-by: Charles Lowell <[email protected]> Co-authored-by: McCoy Patiño <[email protected]> commit aa44b02 Author: Yalin Li <[email protected]> Date: Wed Sep 8 15:17:39 2021 -0700 Run mypy in azure-keyvault-secrets CI (#20507) commit 0af2ce5 Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 13:00:40 2021 -0700 Add Skip.SetTestPipelineVersion to allow overidiing of use of BuildID for test version (#20589) Co-authored-by: Chidozie Ononiwu <[email protected]> commit 50ff989 Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 12:57:35 2021 -0700 Increment package version after release of azure-ai-translation-document (#20596) commit 8be2477 Author: Xiaoxi Fu <[email protected]> Date: Wed Sep 8 12:24:05 2021 -0700 [STG78]Address comments (#20539) commit e089b1b Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 12:17:32 2021 -0700 Increment version for search releases (#20586) Increment package version after release of azure-search-documents commit c0d33d7 Author: annatisch <[email protected]> Date: Wed Sep 8 12:11:49 2021 -0700 Release notes (#20587) commit 1795106 Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 11:42:36 2021 -0700 Increment version for servicebus releases (#20593) Increment package version after release of azure-servicebus commit 82c7e67 Author: Krista Pratico <[email protected]> Date: Wed Sep 8 10:11:08 2021 -0700 update changelog + some edits (#20588) commit c458c42 Author: Rodrigo Souza <[email protected]> Date: Wed Sep 8 09:57:51 2021 -0700 Update README.md (#20574) * Update README.md * Update README.md * Update README.md commit dcbd6d9 Author: Charles Lowell <[email protected]> Date: Wed Sep 8 08:48:03 2021 -0700 Allow overriding client_id for token exchange (#20571) commit 6ccb4ad Author: iscai-msft <[email protected]> Date: Wed Sep 8 11:25:45 2021 -0400 [rest] correctly pickle rest aiohttp responses (#20577) commit 84bd0e9 Author: Azure CLI Bot <[email protected]> Date: Wed Sep 8 13:55:53 2021 +0800 [AutoRelease] t2-web-2021-09-08-84447 (#20583) * CodeGen from PR 15283 in Azure/azure-rest-api-specs Fix WebApps.json for App Service Auth (#15283) * changes * revert some changes * fix 1-01 * done * Update readme.md * update 02-01 * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 60b4e77 Author: Jiefeng Chen <[email protected]> Date: Wed Sep 8 09:53:06 2021 +0800 Update auto-release (#20582) * version auto-calculation rule * single api version rule * Update main.py * additional rule for track1 * when changelog is null * Update PythonSdkLiveTest.yml for Azure Pipelines Add `ISSUE_LINK` * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update livetest_package.txt * Create create_pr.py * Update PythonSdkLiveTest.yml for Azure Pipelines use python script tu create pr * Update PythonSdkLiveTest.yml for Azure Pipelines * create py * Update PythonSdkLiveTest.yml for Azure Pipelines * Update token * Update token * test create_pr * Update PythonSdkLiveTest.yml for Azure Pipelines * Update create_pr.py * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * add_comment * update by jf * Update PythonSdkLiveTest.yml * Update create_auto_release_pr * Update create_auto_release_pr.py * Update create_auto_release_pr.py * Update yaml and py * Update create_auto_release_pr.py * Update create_auto_release_pr.py * Update create_auto_release_pr.py * Update PythonSdkLiveTest.yml * Update create_auto_release_pr.py * Update PythonSdkLiveTest.yml * Update PythonSdkLiveTest.yml for Azure Pipelines * Update create_auto_release_pr.py Co-authored-by: msyyc <[email protected]> commit 63d21c5 Author: Yalin Li <[email protected]> Date: Tue Sep 7 18:09:20 2021 -0700 Run mypy in azure-keyvault-certificates CI (#20525) commit 10979de Author: Azure SDK Bot <[email protected]> Date: Tue Sep 7 16:07:07 2021 -0700 updating proxy to use latest version (#20579) Co-authored-by: seankane-msft <[email protected]> commit 8568a83 Author: ckairen <[email protected]> Date: Tue Sep 7 13:38:57 2021 -0700 Smoke test package verification (#20547) * Checking for package * Update eng/pipelines/templates/jobs/smoke.tests.yml Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Wes Haggard <[email protected]> commit 2a3875f Author: Yalin Li <[email protected]> Date: Tue Sep 7 11:45:45 2021 -0700 Update CHANGELOG.md (#20569) commit 243d884 Author: Sean Kane <[email protected]> Date: Tue Sep 7 14:33:02 2021 -0400 updating codeowners (#20570) * updating codeowners * adding yalin to codeowners for appconfig
zihzhan-msft
added a commit
that referenced
this pull request
Sep 20, 2021
commit b2bdfe6 Author: Travis Prescott <[email protected]> Date: Fri Sep 10 11:48:44 2021 -0700 [Search] Regenerate with latest autorest (#20597) * Regenerate with latest autorest. * Bump azure.core dependency to resolve CI issues. commit 53ea0c0 Author: Jiefeng Chen <[email protected]> Date: Fri Sep 10 16:30:02 2021 +0800 Add auto-close and auto-run-pipline (#20516) * release_iseus_status_auto_reply * issue_aoto_close_revert * Update main.py * Update main.py * Update update_issue_body.py * Update reply_generator.py * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update update_issue_body.py * Update update_issue_body.py * Update main.py * Update reply_generator.py * Update main.py * Update update_issue_body.py * Update main.py * Update scripts/release_issue_status/update_issue_body.py * Update update_issue_body.py * Update main.py * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update scripts/release_issue_status/main.py * Update main.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/update_issue_body.py * Update scripts/release_issue_status/main.py * Update scripts/release_issue_status/update_issue_body.py * Update reply_generator.py * Update main.py * Update scripts/release_issue_status/update_issue_body.py Co-authored-by: msyyc <[email protected]> * Update scripts/release_issue_status/update_issue_body.py Co-authored-by: msyyc <[email protected]> * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update main.py * Update update_issue_body.py * Update main.py * Update scripts/release_issue_status/main.py * Update main.py * Update reply_generator.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update main.py * Update update_issue_body.py * Update main.py * Update update_issue_body.py * Update reply_generator.py * Update update_issue_body.py * Update main.py * Update update_issue_body.py * Update update_issue_body.py * Update update_issue_body.py * Update update_issue_body.py * Update update_issue_body.py * Update main.py * Update main.py * Update release_issue_status.yml for Azure Pipelines * Update main.py * Update reply_generator.py * Add files via upload * Update reply_generator.py * Update update_issue_body.py * Update reply_generator.py * Update auto_pipeline_run.py * Update auto_pipeline_run.py * add auto-close * Update release_issue_status.yml for Azure Pipelines * Update auto_close.py * Update main.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * fix bug * Update main.py * Update auto_close.py * Update auto_close.py * Update main.py * Update reply_generator.py * Update main.py * Update main.py * Update auto_close.py * Update main.py * Update auto-close * Update auto_pipeline_run.py * Update update_issue_body.py * Update auto_pipeline_run.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * Update auto_pipeline_run.py * Add pipeline link * Update pipeline link * Update auto_pipeline_run.py * Update release_issue_status.yml for Azure Pipelines * Update auto_pipeline_run.py * Update requirement.txt * Update auto_pipeline_run.py * Add get_python_pipeline * Update auto_pipeline_run.py * test * test * add outputfolder * add label * Update main.py * Update get_python_pipeline.py * Update main.py * Update auto_pipeline_run.py Co-authored-by: Zed <[email protected]> Co-authored-by: Zed Lei <[email protected]> Co-authored-by: msyyc <[email protected]> commit acfb309 Author: Azure CLI Bot <[email protected]> Date: Fri Sep 10 11:28:30 2021 +0800 [AutoRelease] t2-containerservice-2021-09-09-17236 (#20614) * CodeGen from PR 15954 in Azure/azure-rest-api-specs Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <[email protected]> * update readme for 2021-08-01 sdk generation (#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <[email protected]> * allow disabling of runcommand (#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (#15564) Co-authored-by: Li Ma <[email protected]> * Add CreationData property to Agentpool level in 2021-08-01 API (#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <[email protected]> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <[email protected]> * fix tag typo to match tag convention (#15683) * add workload runtime to agent pool api (#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * fix typo in readme.python.md (#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <[email protected]> * merge recent custom-words.txt changes from main branch to resolve conflicts (#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <[email protected]> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 05aec3d Author: McCoy Patiño <[email protected]> Date: Thu Sep 9 18:41:31 2021 -0700 Redact account keys in recordings (#20537) commit 6a9cb86 Author: Xiang Yan <[email protected]> Date: Thu Sep 9 18:30:08 2021 -0700 Update to latest swagger (#20642) commit cd459a7 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 17:21:31 2021 -0700 Increment version for keyvault releases (#20638) Increment package version after release of azure-keyvault-administration commit bd89c09 Author: luc <[email protected]> Date: Thu Sep 9 17:09:01 2021 -0700 Update Communication Chat Swagger & Tests Record (#20578) * update swagger * update changelog commit 71871eb Author: Rakshith Bhyravabhotla <[email protected]> Date: Thu Sep 9 15:41:35 2021 -0700 Update CHANGELOG.md (#20631) commit 28bb632 Author: swathipil <[email protected]> Date: Thu Sep 9 15:35:48 2021 -0700 [SchemaRegistry] update Avro version + changelog (#20624) fixes: #20606 commit 3d29229 Author: Leighton Chen <[email protected]> Date: Thu Sep 9 15:06:15 2021 -0700 rpc (#20563) commit 5c1cf92 Author: Rakshith Bhyravabhotla <[email protected]> Date: Thu Sep 9 14:32:22 2021 -0700 Prepare for release (#20627) commit 43a17d2 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 14:01:18 2021 -0700 Install az module if not installed in deploy-stress-tests.ps1 (#20605) Co-authored-by: Ben Broderick Phillips <[email protected]> commit 6d34b90 Author: Yalin Li <[email protected]> Date: Thu Sep 9 13:36:32 2021 -0700 Address incorrect links in README.md (#20626) commit 0c0b975 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 13:34:52 2021 -0700 Increment version for keyvault releases (#20625) Increment package version after release of azure-keyvault-keys commit 0e5e53d Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 11:03:54 2021 -0700 Explicitly exit 0 so a failed inner command (like mvn) doesn't propagate up to a failure of the pipeline (#20609) Co-authored-by: Daniel Jurek <[email protected]> commit 476acd5 Author: McCoy Patiño <[email protected]> Date: Thu Sep 9 11:02:40 2021 -0700 [Identity] Resolve CredScan warnings (#20543) commit 853db90 Author: Azure SDK Bot <[email protected]> Date: Thu Sep 9 10:59:29 2021 -0700 Increment version for identity releases (#20620) Increment package version after release of azure-identity commit 92a676d Author: Xiang Yan <[email protected]> Date: Thu Sep 9 09:15:26 2021 -0700 update changelog (#20619) commit 7373db2 Author: Yalin Li <[email protected]> Date: Wed Sep 8 18:49:45 2021 -0700 Run mypy in azure-keyvault-keys CI (#20545) commit 51f09fa Author: McCoy Patiño <[email protected]> Date: Wed Sep 8 18:21:08 2021 -0700 [Key Vault] Update changelogs for release (#20607) commit bad587d Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 17:28:20 2021 -0700 Sync eng/common directory with azure-sdk-tools repository (#20604) commit 1f2218a Author: swathipil <[email protected]> Date: Wed Sep 8 17:13:33 2021 -0700 [SchemaRegistry] update API for consistency (#20538) * changes * updated failing tests * keep Dict for now * pylint errors * nit * add recordings * tests recordings commit 40c9060 Author: Xiang Yan <[email protected]> Date: Wed Sep 8 16:01:33 2021 -0700 update release date (#20601) commit c11e835 Author: Xiang Yan <[email protected]> Date: Wed Sep 8 15:29:40 2021 -0700 add interactive_browser_client_id (#20591) * add interactive_browser_client_id * Update sdk/identity/azure-identity/azure/identity/_credentials/default.py Co-authored-by: Charles Lowell <[email protected]> * Update sdk/identity/azure-identity/azure/identity/_credentials/default.py Co-authored-by: Charles Lowell <[email protected]> * update * update * update * update * update * Update sdk/identity/azure-identity/azure/identity/_credentials/default.py Co-authored-by: McCoy Patiño <[email protected]> * update Co-authored-by: Charles Lowell <[email protected]> Co-authored-by: McCoy Patiño <[email protected]> commit aa44b02 Author: Yalin Li <[email protected]> Date: Wed Sep 8 15:17:39 2021 -0700 Run mypy in azure-keyvault-secrets CI (#20507) commit 0af2ce5 Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 13:00:40 2021 -0700 Add Skip.SetTestPipelineVersion to allow overidiing of use of BuildID for test version (#20589) Co-authored-by: Chidozie Ononiwu <[email protected]> commit 50ff989 Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 12:57:35 2021 -0700 Increment package version after release of azure-ai-translation-document (#20596) commit 8be2477 Author: Xiaoxi Fu <[email protected]> Date: Wed Sep 8 12:24:05 2021 -0700 [STG78]Address comments (#20539) commit e089b1b Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 12:17:32 2021 -0700 Increment version for search releases (#20586) Increment package version after release of azure-search-documents commit c0d33d7 Author: annatisch <[email protected]> Date: Wed Sep 8 12:11:49 2021 -0700 Release notes (#20587) commit 1795106 Author: Azure SDK Bot <[email protected]> Date: Wed Sep 8 11:42:36 2021 -0700 Increment version for servicebus releases (#20593) Increment package version after release of azure-servicebus commit 82c7e67 Author: Krista Pratico <[email protected]> Date: Wed Sep 8 10:11:08 2021 -0700 update changelog + some edits (#20588) commit c458c42 Author: Rodrigo Souza <[email protected]> Date: Wed Sep 8 09:57:51 2021 -0700 Update README.md (#20574) * Update README.md * Update README.md * Update README.md commit dcbd6d9 Author: Charles Lowell <[email protected]> Date: Wed Sep 8 08:48:03 2021 -0700 Allow overriding client_id for token exchange (#20571) commit 6ccb4ad Author: iscai-msft <[email protected]> Date: Wed Sep 8 11:25:45 2021 -0400 [rest] correctly pickle rest aiohttp responses (#20577) commit 84bd0e9 Author: Azure CLI Bot <[email protected]> Date: Wed Sep 8 13:55:53 2021 +0800 [AutoRelease] t2-web-2021-09-08-84447 (#20583) * CodeGen from PR 15283 in Azure/azure-rest-api-specs Fix WebApps.json for App Service Auth (#15283) * changes * revert some changes * fix 1-01 * done * Update readme.md * update 02-01 * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines> commit 60b4e77 Author: Jiefeng Chen <[email protected]> Date: Wed Sep 8 09:53:06 2021 +0800 Update auto-release (#20582) * version auto-calculation rule * single api version rule * Update main.py * additional rule for track1 * when changelog is null * Update PythonSdkLiveTest.yml for Azure Pipelines Add `ISSUE_LINK` * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update livetest_package.txt * Create create_pr.py * Update PythonSdkLiveTest.yml for Azure Pipelines use python script tu create pr * Update PythonSdkLiveTest.yml for Azure Pipelines * create py * Update PythonSdkLiveTest.yml for Azure Pipelines * Update token * Update token * test create_pr * Update PythonSdkLiveTest.yml for Azure Pipelines * Update create_pr.py * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * Update PythonSdkLiveTest.yml for Azure Pipelines * add_comment * update by jf * Update PythonSdkLiveTest.yml * Update create_auto_release_pr * Update create_auto_release_pr.py * Update create_auto_release_pr.py * Update yaml and py * Update create_auto_release_pr.py * Update create_auto_release_pr.py * Update create_auto_release_pr.py * Update PythonSdkLiveTest.yml * Update create_auto_release_pr.py * Update PythonSdkLiveTest.yml * Update PythonSdkLiveTest.yml for Azure Pipelines * Update create_auto_release_pr.py Co-authored-by: msyyc <[email protected]> commit 63d21c5 Author: Yalin Li <[email protected]> Date: Tue Sep 7 18:09:20 2021 -0700 Run mypy in azure-keyvault-certificates CI (#20525) commit 10979de Author: Azure SDK Bot <[email protected]> Date: Tue Sep 7 16:07:07 2021 -0700 updating proxy to use latest version (#20579) Co-authored-by: seankane-msft <[email protected]> commit 8568a83 Author: ckairen <[email protected]> Date: Tue Sep 7 13:38:57 2021 -0700 Smoke test package verification (#20547) * Checking for package * Update eng/pipelines/templates/jobs/smoke.tests.yml Co-authored-by: Wes Haggard <[email protected]> Co-authored-by: Wes Haggard <[email protected]> commit 2a3875f Author: Yalin Li <[email protected]> Date: Tue Sep 7 11:45:45 2021 -0700 Update CHANGELOG.md (#20569) commit 243d884 Author: Sean Kane <[email protected]> Date: Tue Sep 7 14:33:02 2021 -0400 updating codeowners (#20570) * updating codeowners * adding yalin to codeowners for appconfig
iscai-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
* CodeGen from PR 15954 in Azure/azure-rest-api-specs Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <[email protected]> * update readme for 2021-08-01 sdk generation (#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <[email protected]> * allow disabling of runcommand (#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (#15564) Co-authored-by: Li Ma <[email protected]> * Add CreationData property to Agentpool level in 2021-08-01 API (#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <[email protected]> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <[email protected]> * fix tag typo to match tag convention (#15683) * add workload runtime to agent pool api (#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * fix typo in readme.python.md (#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <[email protected]> * merge recent custom-words.txt changes from main branch to resolve conflicts (#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <[email protected]> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.