fix retry_interval: set it to 1 second instead of 1000 seconds #14357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks like it was a typo introduced in Azure#5785 (review) The review comment makes me think the author meant 1 second, but maybe thought it was milliseconds. time.sleep and asyncio.sleep arguments are both in seconds in Azure#14067 we are experiencing timeouts after ~15 to 16 min (matching 1000 seconds) that are not solved by configuring timeouts in the client
ghost
added
Azure.Core
customer-reported
|
Thank you for your contribution vbarbaresi! We will review the pull request and get back to you soon. |
|
|
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This looks unrelated to the issue I linked, I don't know where this code is used but it wouldn't hurt to fix it anyway |
xiangyan99
approved these changes
Nov 9, 2020
|
@vbarbaresi Good catch and thanks for your contribution. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like it was a typo introduced in #5785 (review)
The review comment makes me think the author meant 1 second, but maybe thought it was milliseconds.
This
retry_intervalis fed totime.sleepandasyncio.sleepBoth these methods' arguments are in seconds
in #14067 we are experiencing timeouts after ~15 to 16 min (matching 1000 seconds) that are not solved by configuring timeouts in the client