[metricsadvisor] get pylint clean #14094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapratico
requested review from
danieljurek,
lmazuel,
mayurid,
mitchdenny,
scbedd and
weshaggard
as code owners
kristapratico
removed request for
mitchdenny,
lmazuel,
danieljurek,
mayurid,
weshaggard and
scbedd
kristapratico
commented
Sep 28, 2020
| @@ -612,7 +621,7 @@ def list_metric_dimension_values(self, metric_id, dimension_name, **kwargs): | |||
| **kwargs) | |||
|
|
|||
| @distributed_trace | |||
| def list_metrics_series_data(self, metric_id, start_time, end_time, filter, **kwargs): | |||
| def list_metrics_series_data(self, metric_id, start_time, end_time, series_to_filter, **kwargs): | |||
There was a problem hiding this comment.
original parameter name filter was overshadowing the built-in filter. Other languages call this parameter series_to_filter so I renamed it.
|
/azp run python - storage - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xiangyan99
previously approved these changes
Sep 28, 2020
|
/azp run python - metricsadvisor - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xiangyan99
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.