Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] Test and failure improvements #13345

Merged
merged 7 commits into from
Aug 31, 2020
Merged

[ServiceBus] Test and failure improvements #13345

merged 7 commits into from
Aug 31, 2020

Conversation

KieranBrantnerMagee
Copy link
Member

@KieranBrantnerMagee KieranBrantnerMagee commented Aug 26, 2020 •
edited
Loading

A smattering of small test improvements.

  • ensure incorrect_queue_conn_str test validates success and failure cases and consistency of different entry points.
  • ensure specificity of authorization/authenication errors
  • Begin adding "raises" stanzas to docstrings.
  • normalize convert_connection_string_to_kwargs to throw AuthenticationError on misaligned entity_path
  • fix flaky scheduled tests: both moving away from the receive_messages calls in tests, and making scheduled vs enqueue time a <= relationshi rather than ==.
  • similarly, if we're using the "source of truth" internal time for max wait time valdiation, must be<= since the milliseconds can actually be EXACT.

@KieranBrantnerMagee
Small but important: does not import ServiceBusSession any more.
2dd5506 
A smattering of small test improvements.
- ensure incorrect_queue_conn_str test validates success and failure cases and consistency of different entry points.
- ensure specificity of authorization/authenication errors
- Begin adding "raises" stanzas to docstrings.
- normalize convert_connection_string_to_kwargs to throw AuthenticationError on misaligned entity_path
- fix flaky scheduled tests: both moving away from the receive_messages calls in tests, and making scheduled vs enqueue time a <= relationshi rather than ==.
- similarly, if we're using the "source of truth" internal time for max wait time valdiation, must be<= since the milliseconds can actually be EXACT.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Aug 26, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] September milestone Aug 26, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Aug 26, 2020
@KieranBrantnerMagee KieranBrantnerMagee changed the title Small but important: does not import ServiceBusSession any more. [ServiceBus] Test and failure improvements Aug 26, 2020
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Update test_sb_client.py
09722ae 
Add missing ServiceBusAuthorizationError as import for more precise tests.
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Update test_queues_async.py
57a956f 
Fix test by making for loop properly async when swapping in the iterator.
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee KieranBrantnerMagee marked this pull request as ready for review August 27, 2020 17:25
@KieranBrantnerMagee
PR comments;
f82ac9e 
remove session from aio (adjust changelog)
re-adjust test to use batch as intended.
@KieranBrantnerMagee
merge from upstream
850173c
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee
readd servicebussession on Adam's good point that it may interfere wi…
a0cca11 
…th type hinting that uses the public path currently. Should do this while adjusting to try and use internal paths while keeping an eye on typechecking; will be larger work.
@KieranBrantnerMagee
merge from upstream master
bbe9dd2
@KieranBrantnerMagee
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KieranBrantnerMagee KieranBrantnerMagee merged commit c77746b into Azure:master Aug 31, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 1, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
318b112 
…into add_redacted_text

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  Switch retry (Azure#13264)
  [ServiceBus] ServiceBusClient close spawned children (Azure#13077)
  fixing version issue by not overwriting the version with the semantic… (Azure#13411)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 1, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
05be0b7 
…into expose_parse_vault_id

* 'master' of https://github.com/Azure/azure-sdk-for-python: (37 commits)
  [text analytics] add versionadded sphinx documentation (Azure#13450)
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  Switch retry (Azure#13264)
  [ServiceBus] ServiceBusClient close spawned children (Azure#13077)
  fixing version issue by not overwriting the version with the semantic… (Azure#13411)
  clean up reference and tests (Azure#13412)
  Consistent returns (Azure#13245)
  [text analytics] return None for offset and length for v3.0 (Azure#13382)
  edit all authentication files and add a test (Azure#13355)
  Add managed_identity_client_id argument to DefaultAzureCredential (Azure#13218)
  [text analytics] add string-index-type support (Azure#13378)
  [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383)
  Send spec (Azure#13143)
  Anomaly Detector 3.0.0b2 release (Azure#13351)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 2, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f7625ea 
…into link_om_sample

* 'master' of https://github.com/Azure/azure-sdk-for-python: (23 commits)
  Int32 serialization (Azure#13452)
  add output to opinion mining sample (Azure#13494)
  Add Document w/ Eng Sys Checks (Azure#13492)
  update version (Azure#13495)
  Remove resources post test (Azure#13379)
  bing_id -> bing_entity_search_api_id (Azure#13491)
  [EventGrid] Read me + improve docstrings (Azure#13484)
  Build AuthenticationRecords from ADFS identity tokens (Azure#13341)
  Support Subject Name/Issuer authentication (Azure#13350)
  Add KeyVaultAccessControlClient for data plane RBAC (Azure#13372)
  [text analytics] Add redacted_text (Azure#13449)
  add python sdk sample (Azure#13338)
  [text analytics] add versionadded sphinx documentation (Azure#13450)
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  ...
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Sep 4, 2020
@KieranBrantnerMagee @rakshith91
[ServiceBus] Test and failure improvements (Azure#13345)
9d8d048 
A smattering of small test improvements.
- ensure incorrect_queue_conn_str test validates success and failure cases and consistency of different entry points.
- ensure specificity of authorization/authenication errors
- Begin adding "raises" stanzas to docstrings.
- normalize convert_connection_string_to_kwargs to throw AuthenticationError on misaligned entity_path
- fix flaky scheduled tests: both moving away from the receive_messages calls in tests, and making scheduled vs enqueue time a <= relationshi rather than ==.
- similarly, if we're using the "source of truth" internal time for max wait time valdiation, must be<= since the milliseconds can actually be EXACT.
- Add missing ServiceBusAuthorizationError as import for more precise tests.
- ensure batch fetching in tests is recurrent to make more robust.
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 16, 2021
CodeGen from PR 13345 in Azure/azure-rest-api-specs
06ee4b8 
Adding AAD based security principal for PublicPreview (Azure#13345)

* Adding AAD based security principal for PublicPreview

* addressing comments

* addressing comments

* fixing roleName field

* fixing minor prettier issue

* fixing examples

* running prettier check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@rakshith91 rakshith91 Awaiting requested review from rakshith91

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] September
Development

Successfully merging this pull request may close these issues.
2 participants
@KieranBrantnerMagee @yunhaoling