Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage-Blob] Quick Query API #11991
[Storage-Blob] Quick Query API #11991
Changes from 23 commits
09c2564
2afff10
69c319a
e12c1c5
a2e5c66
cf088de
0920887
b09eddc
0ed1910
b55a728
a5752e5
de6e434
020cf45
fb17fcb
bc3b153
4ec52e1
b70c252
1bb8177
bdd3a55
6cacb58
6b48df8
e98bd19
5baddd5
d485325
50964e5
7431e1d
c56ed85
e2cb444
1d6fd21
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does operation_on_error sound better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modelled the parameter naming based on this:
https://docs.python.org/3.8/library/codecs.html#error-handlers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasobol-msft thoughts? how about error handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I posted comment next to implementation below. I believe this change doesn't follow our feature specification and I'd recommend to change in back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry that I told you wrong about this"By default the data will be returned as it is represented in the blob", I tried again and the it shows the default output is also Delimited Text data. While I think it makes more sense to return the format that the blob presently have. I will add a commit to make output format default to the existing blob format.