Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ClientSecretCredential to use AadClient #11718

Merged
merged 3 commits into from
Jun 4, 2020

Conversation

chlowell
Copy link
Member

No user-facing changes here, these are all internal adjustments to make it easier to add new caching features to this credential.

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels May 29, 2020
@chlowell chlowell requested a review from xiangyan99 May 29, 2020 23:55
@chlowell chlowell requested a review from schaabs as a code owner May 29, 2020 23:55
schaabs
schaabs previously approved these changes Jun 4, 2020
@chlowell chlowell force-pushed the client-secret-aadclient branch from 45fda4c to 80127c8 Compare June 4, 2020 15:57
@chlowell chlowell requested a review from schaabs June 4, 2020 15:58
@chlowell
Copy link
Member Author

chlowell commented Jun 4, 2020

/check-enforcer evaluate

@chlowell chlowell merged commit 0ec1601 into Azure:master Jun 4, 2020
@chlowell chlowell deleted the client-secret-aadclient branch June 4, 2020 16:18
xiangyan99 added a commit that referenced this pull request Jun 4, 2020
* [HDInsight] Fix hdi test failure (#11806)

* Initial generation Synapse autorest v5

* Fix empty model generation

* Fix Test Failure:
Skip 3 test case: test_create_with_adlsgen1, test_create_with_additional_storage, test_oms_on_running_cluster
Rename test_http_extend to test_gateway_setting for http settings is
replaced with gateway settings

Co-authored-by: Laurent Mazuel <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>

* disable some by design bandit warnings (#11495)

* disable some by design bandit warnings

* Packaging update of azure-mgmt-datalake-analytics

Co-authored-by: Azure SDK Bot <[email protected]>

* Increment package version after release of azure_core (#11795)

* Use subject claim as home_account_id when no client_info (#11639)

* Refactor ClientCertificateCredential to use AadClient (#11719)

* Refactor ClientSecretCredential to use AadClient (#11718)

* [Cosmos] Fixed incorrect ID type error (#11798)

* Fixed incorrect ID type error

* Fix pylint

* [text analytics] Update readme (#11796)

* try something (#11797)

* Search refactoring 3 (#11804)

* create_or_update takes object

* rename is_hidden to hidden

* fix types

* updates

Co-authored-by: aim-for-better <[email protected]>
Co-authored-by: Laurent Mazuel <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: annatisch <[email protected]>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: Krista Pratico <[email protected]>
xiangyan99 added a commit that referenced this pull request Jun 5, 2020
* search method only takes search_text

* update

* Add AzureCliCredential and VSCodeCredential to public API (#11790) (#11805)

Co-authored-by: Charles Lowell <[email protected]>

* get master (#11823)

* [HDInsight] Fix hdi test failure (#11806)

* Initial generation Synapse autorest v5

* Fix empty model generation

* Fix Test Failure:
Skip 3 test case: test_create_with_adlsgen1, test_create_with_additional_storage, test_oms_on_running_cluster
Rename test_http_extend to test_gateway_setting for http settings is
replaced with gateway settings

Co-authored-by: Laurent Mazuel <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>

* disable some by design bandit warnings (#11495)

* disable some by design bandit warnings

* Packaging update of azure-mgmt-datalake-analytics

Co-authored-by: Azure SDK Bot <[email protected]>

* Increment package version after release of azure_core (#11795)

* Use subject claim as home_account_id when no client_info (#11639)

* Refactor ClientCertificateCredential to use AadClient (#11719)

* Refactor ClientSecretCredential to use AadClient (#11718)

* [Cosmos] Fixed incorrect ID type error (#11798)

* Fixed incorrect ID type error

* Fix pylint

* [text analytics] Update readme (#11796)

* try something (#11797)

* Search refactoring 3 (#11804)

* create_or_update takes object

* rename is_hidden to hidden

* fix types

* updates

Co-authored-by: aim-for-better <[email protected]>
Co-authored-by: Laurent Mazuel <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: annatisch <[email protected]>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: Krista Pratico <[email protected]>

* rename AnalyzeText to AnalyzeTextRequest

* fixes

* update

* update changelog

* update

* add types

* update

* rename batch methods

* update

* update

* update

* updates

Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: aim-for-better <[email protected]>
Co-authored-by: Laurent Mazuel <[email protected]>
Co-authored-by: Zhenyu Zhou <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: Azure SDK Bot <[email protected]>
Co-authored-by: annatisch <[email protected]>
Co-authored-by: iscai-msft <[email protected]>
Co-authored-by: Krista Pratico <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Nov 19, 2020
[Hub Generated] Review request for Microsoft.StoragePool to add version preview/2020-03-15-preview (Azure#11718)

* New Readme Config File

* New Go Language Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New Ruby Language Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* StoragePool RP swagger definition

* Added missing file

* Added missing title and description

* Prettier fix

* Fixing js code gen issue

Co-authored-by: Harshitha Akkaraju <[email protected]>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Nov 19, 2020
[Hub Generated] Review request for Microsoft.StoragePool to add version preview/2020-03-15-preview (Azure#11718)

* New Readme Config File

* New Go Language Readme Config File

* New Typescript Language Readme Config File

* New Python Language Readme Config File

* New C# Language Readme Config File

* New Ruby Language Readme Config File

* New Swagger Spec File

* New Swagger Example Spec File

* StoragePool RP swagger definition

* Added missing file

* Added missing title and description

* Prettier fix

* Fixing js code gen issue

Co-authored-by: Harshitha Akkaraju <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants