-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove DataSourceCredentials #11605
remove DataSourceCredentials #11605
Conversation
Remove DataSourceCredentials |
rename SearchIndexerDataSource to SearchIndexerDataSourceConnection |
'description': {'key': 'description', 'type': 'str'}, | ||
'type': {'key': 'type', 'type': 'str'}, | ||
'connection_string': {'key': 'connectionString', 'type': 'str'}, | ||
'container': {'key': 'container', 'type': 'SearchIndexerDataContainer'}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "flattenned" too like the connection string? perhaps just take in a container name + kwargs and create the DataContainer ourselves? Just a possible suggestion - no strong opinion
|
||
@distributed_trace | ||
def create_or_update_datasource(self, data_source, name=None, **kwargs): | ||
# type: (SearchIndexerDataSource, Optional[str], **Any) -> Dict[str, Any] | ||
# type: (SearchIndexerDataSourceConnection, Optional[str], **Any) -> SearchIndexerDataSourceConnection |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do this in a different PR prolly - but we must allow individual keywords only to update the datasource - which if present would override the datasource. (See skillsets for example)
…into feature/text_analytics_v3.0 * 'master' of https://github.com/Azure/azure-sdk-for-python: Release azure mgmt containerregistry (#11460) Prepare core 1.6.0 on master (#11610) Add force parameter to SwaggerToSdk CLI (#11609) LRO continuation_token (#10801) Remove unecessary import (#11606) Fix Cleanup failing on 3.8.3 (#11607) remove DataSourceCredentials (#11605) Search synonym map (#11590) Fix copy tests (#11594) Make use_training_labels positional required (#11529) Search refactoring 2 (#11584) Search refactoring 1 (#11572)
No description provided.