Rename to completed_on and requested_on in the CustomFormModel #11592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
iscai-msft
reviewed
May 21, 2020
| @@ -65,8 +65,8 @@ async def manage_custom_models(self): | |||
| custom_model = await form_training_client.get_custom_model(model_id=first_model.model_id) | |||
| print("Model ID: {}".format(custom_model.model_id)) | |||
| print("Status: {}".format(custom_model.status)) | |||
| print("Created on: {}".format(custom_model.created_on)) | |||
| print("Last modified: {}".format(custom_model.last_modified)) | |||
| print("Created on: {}".format(custom_model.requested_on)) | |||
There was a problem hiding this comment.
Should switch the text in these print statements too
| @@ -16,7 +16,9 @@ | |||
| - `USReceiptType` is renamed to `ReceiptType` | |||
| - `use_training_labels` is now a required positional param in the `begin_training` APIs. | |||
| - `stream` and `url` parameters found on methods for `FormRecognizerClient` have been renamed to `form` and `form_url`, respectively. | |||
| For recognize receipt methods, parameters have been renamed to `receipt` and `receipt_url`. | |||
| - For recognize receipt methods, parameters have been renamed to `receipt` and `receipt_url`. | |||
There was a problem hiding this comment.
Should also update the readme, i.e. here (i think there are two code snippets that need updating): https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/formrecognizer/azure-ai-formrecognizer/README.md#train-a-model
rakshith91
force-pushed
the
custom_form_created
branch
from
59feb11 to
d6a9ff8
Compare
| For recognize receipt methods, parameters have been renamed to `receipt` and `receipt_url`. | ||
| - For recognize receipt methods, parameters have been renamed to `receipt` and `receipt_url`. | ||
| - `created_on` and `last_modified` are renamed to `requested_on` and `completed_on` in the | ||
| `CustomForm` models. |
There was a problem hiding this comment.
I would spell out the models that changed since there were only two
sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py
Outdated
Show resolved
Hide resolved
rakshith91
commented
May 26, 2020
Co-authored-by: Krista Pratico <[email protected]>
sdk/formrecognizer/azure-ai-formrecognizer/azure/ai/formrecognizer/_models.py
Outdated
Show resolved
Hide resolved
…izer/_models.py Co-authored-by: Krista Pratico <[email protected]>
kristapratico
approved these changes
May 26, 2020
iscai-msft
approved these changes
May 26, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
May 27, 2020
…into models_to_submodels * 'master' of https://github.com/Azure/azure-sdk-for-python: [text analytics] merging feature branch into master (Azure#11632) regen swagger and make list_indexes pageable (Azure#11635) Sync eng/common directory with azure-sdk-tools repository (Azure#11566) Rename to completed_on and requested_on in the CustomFormModel (Azure#11592) [formrecognizer] model_id param validation (Azure#11569) [Batch] Fix issue in latest REST API (Azure#11604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11283