Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage][LiveTest]Fix Dependency #10896

Closed
wants to merge 2 commits into from
Closed

Conversation

xiafu-msft
Copy link
Contributor

No description provided.

Copy link
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't change dependencies on a package without a specific reason, please update the issue with specific feature that you need from recent azure-core / azure-stroage-blob to justfy the need for an update in the main setup.py

Updating the main setup.py that impacts customers solely for CI fixes need is wrong.

@xiafu-msft
Copy link
Contributor Author

Hi @lmazuel
I assumed datalake need QuickQuery feature from azure-storage-blob 12.3.1, and azure-storage-blob 12.3.1 is depending on azure-core 1.4.
It's also possible that DataLake doesn't support QQ, we are still waiting for service confirmation!

So if DataLake supports QQ, is there anything I should change for this pr?
If DataLake doesn't support QQ I will close this pr.

@lmazuel
Copy link
Member

lmazuel commented Apr 21, 2020

@xiafu-msft you should at least not try to deal with indirect dependency requirement by yourself. If datalake doesn't need azure-core 1.4.0, then leave it to what it needs and pip will follow blob to know if blob has a requirement to do more. IOW:

  • your setup.py says azure-core >= 1.2.2
  • your setup.py says azure-storage-blob>=12.3.1 that says azure-core>=1.4.0
  • pip will correctly infer that it needs >= 1.4.0, and you didn't have to change your setup.py

If indeed QQ is needed and available only after azure-storage-blob>=12.3.1, then that change is good.

@xiafu-msft
Copy link
Contributor Author

Hi @lmazuel
Thanks for the detailed suggestion!
I will keep azure-core >= 1.2.2 in setup.py
For the blob dependency change, I'd wait until the STG73(QuickQuery feature is there) release. Because we just planned to do a May release. So It's too early to do this dependency change.

While we can merge this pr to stg73 branch to make sure we will change the dependency when releasing stg73 features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants