Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
identity_vscode_credential #10840
identity_vscode_credential #10840
Changes from 23 commits
0002805
b1e79de
13fd676
d356ba6
41b0394
526470d
dc671f2
5a47894
c797482
25de404
f48fdd4
a77e336
9f5ad5d
d155f80
015f1f7
bfa2ea1
16873bd
58844b9
05694a9
671d5ea
921b7a2
3911b88
f313ba4
283a055
9974361
4e7b9c4
bbe7a20
94b152b
657617c
426dea7
f9a2abf
593a62f
0805e74
eaf10cb
e1dab12
9c33cfd
d072e20
6024a9a
a63e157
a8d45c0
2fca38a
3866a93
ebb5df2
595cdea
246ab2d
af482e6
57953ba
022f376
7e15ddd
975f6ed
767906f
1e10649
cf54345
e43a74f
4fe1be3
0fd89e6
5524ea9
ff9d532
e6b83ca
9232a3b
9ea845e
77f8838
0f69230
ec1f0a3
4fadaf3
435fdce
cb74ce2
a402f3b
853dd3e
54d1b48
75624b8
ed1db0c
6fc8708
7d36ad5
6f8ae61
42270b8
5c8bcec
77cc4d8
10a9e43
ff8e1c7
8efee5c
a5dc253
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these three lines could just be
cred = cred_blob.decode("utf-16-le")
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried both cred = str(cred_blob, "utf-16") & cred = str(cred_blob, "utf-16-le"), neither of them worked correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the value on my machine for this, they're storing it as ASCII, not UTF-16. (Specifically, it looks like URL-safe base64 encoding without padding, but that probably doesn't matter as I think you just use this directly, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. In our case, we use it directly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover copy pasta here.