Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code sample for ManagedIdentityCredential #10667

Closed
wants to merge 1 commit into from

Conversation

tniek
Copy link

@tniek tniek commented Apr 4, 2020

Found the sample section not very clear, as far as other credentials are concerned; therefore, I've added sample code we're using for our product.

Found the sample section not very clear, as far as other credentials are concerned; therefore, I've added sample code we're using for our product.
@tniek tniek requested review from chlowell and schaabs as code owners April 4, 2020 04:19
@chlowell
Copy link
Member

chlowell commented Apr 8, 2020

Hi @tniek, thanks for contributing! I'm reluctant to add a sample for user-assigned managed identity because it's more advanced than what we typically foreground in the readme. In fact, we intend to revise the readme to sharpen its focus on basic getting started scenarios. Still, I can see the reference docs could be clearer about user-assigned managed identities, so I've noted that in an issue tracking doc revisions (#10734).

@chlowell
Copy link
Member

Thanks again for contributing this pull request. I'm closing it because the scenario doesn't fit in to the readme. We'll clarify user assigned managed identity in the next revision of our documentation.

@chlowell chlowell closed this Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants