[Core] Updates to multipart support #10487
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
FYI @pakrym |
lmazuel
reviewed
Apr 1, 2020
| @@ -194,7 +194,8 @@ def run(self, request, **kwargs): | |||
| :return: The PipelineResponse object | |||
| :rtype: ~azure.core.pipeline.PipelineResponse | |||
| """ | |||
| self._prepare_multipart_mixed_request(request) | |||
| multipart_options = kwargs.pop("multipart_options", None) or {} | |||
There was a problem hiding this comment.
Do we want this parameter to be hidden?
|
Separated first part out into separate PR to be merged first: |
|
Is this one done or still needed? I saw it referenced in another bug that sounded completed. |
|
Thanks @Petermarcu - this is still needed (though part of it was moved out into another PR and merged). I will get this one updated and ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fixes for #10484 and #10485
Also contributes to #9534