Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Batch Data plane #10477

Merged
merged 3 commits into from
Mar 26, 2020
Merged

Update Batch Data plane #10477

merged 3 commits into from
Mar 26, 2020

Conversation

bgklein
Copy link
Contributor

@bgklein bgklein commented Mar 24, 2020

No description provided.

@adxsdk6
Copy link

adxsdk6 commented Mar 24, 2020

Can one of the admins verify this patch?

@bgklein bgklein requested a review from lmazuel March 24, 2020 20:17
@bgklein
Copy link
Contributor Author

bgklein commented Mar 24, 2020

@lmazuel also for review as had to change storage_preparer.

Saving async for probably v10(its own release probably) to avoid blocking feature release

@bgklein bgklein force-pushed the brklein/batch/mar20 branch from 3be2d16 to bc6d511 Compare March 24, 2020 21:46
@bgklein bgklein force-pushed the brklein/batch/mar20 branch from bc6d511 to 2b6f32e Compare March 24, 2020 21:47
xingwu1
xingwu1 previously approved these changes Mar 26, 2020
@@ -145,8 +129,6 @@ class NodeFilePaged(Paged):
def __init__(self, *args, **kwargs):

super(NodeFilePaged, self).__init__(*args, **kwargs)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the lines.

@@ -25,8 +25,6 @@ class ApplicationSummaryPaged(Paged):
def __init__(self, *args, **kwargs):

super(ApplicationSummaryPaged, self).__init__(*args, **kwargs)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't remove the lines.

@bgklein bgklein merged commit 84ecb1b into Azure:master Mar 26, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 27, 2020
…into shared_credential

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Update install link
  [Event Hubs]  Put uamqp.Message.properties into EventData.system_properties (Azure#10508)
  Sync eng/common directory with azure-sdk-tools repository (Azure#10531)
  Prevent DefaultAzureCredential changing authentication method (Azure#10349)
  Update Batch Data plane (Azure#10477)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 27, 2020
…into shared_credential_ta

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  Update install link
  [Event Hubs]  Put uamqp.Message.properties into EventData.system_properties (Azure#10508)
  Sync eng/common directory with azure-sdk-tools repository (Azure#10531)
  Prevent DefaultAzureCredential changing authentication method (Azure#10349)
  Update Batch Data plane (Azure#10477)
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 27, 2020
…re-sdk-for-python into shared_credential_search

* 'shared_credential' of https://github.com/iscai-msft/azure-sdk-for-python:
  fixed test
  Update install link
  [Event Hubs]  Put uamqp.Message.properties into EventData.system_properties (Azure#10508)
  Sync eng/common directory with azure-sdk-tools repository (Azure#10531)
  Prevent DefaultAzureCredential changing authentication method (Azure#10349)
  Update Batch Data plane (Azure#10477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants