Add EnvVar AZURE_AUTHORITY_HOST #10357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
chlowell
requested changes
Mar 18, 2020
sdk/identity/azure-identity/azure/identity/_credentials/default.py
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Mar 19, 2020
chlowell
previously approved these changes
Mar 20, 2020
sdk/identity/azure-identity/azure/identity/_internal/shared_token_cache.py
Outdated
Show resolved
Hide resolved
schaabs
previously approved these changes
Mar 25, 2020
|
Can you please add tests? |
v-xuto
dismissed stale reviews from schaabs and chlowell
The base branch was changed.
chlowell
requested changes
Apr 2, 2020
chlowell
reviewed
Apr 3, 2020
jongio
previously approved these changes
Apr 6, 2020
chlowell
approved these changes
Apr 6, 2020
xiangyan99
reviewed
Apr 6, 2020
| @@ -34,7 +34,7 @@ class AadClientBase(ABC): | |||
|
|
|||
| def __init__(self, tenant_id, client_id, cache=None, **kwargs): | |||
| # type: (str, str, Optional[TokenCache], **Any) -> None | |||
| authority = kwargs.pop("authority", KnownAuthorities.AZURE_PUBLIC_CLOUD) | |||
| authority = kwargs.pop("authority", None) or get_default_authority() | |||
There was a problem hiding this comment.
Not authority = kwargs.pop("authority", get_default_authority())?
There was a problem hiding this comment.
Yes, for two reasons:
- to make
authority=Noneget the default value - to prevent invoking
get_default_authoritywhen a value was passed
xiangyan99
reviewed
Apr 6, 2020
| @@ -10,6 +10,7 @@ | |||
|
|
|||
| from .. import CredentialUnavailableError | |||
| from .._constants import KnownAuthorities | |||
There was a problem hiding this comment.
Yes, it's used to build the sets of authority aliases.
xiangyan99
reviewed
Apr 6, 2020
| @@ -61,7 +62,7 @@ class DefaultAzureCredential(ChainedTokenCredential): | |||
| """ | |||
|
|
|||
| def __init__(self, **kwargs): | |||
| authority = kwargs.pop("authority", None) or KnownAuthorities.AZURE_PUBLIC_CLOUD | |||
| authority = kwargs.pop("authority", None) or get_default_authority() | |||
There was a problem hiding this comment.
Not authority = kwargs.pop("authority", get_default_authority())?
xiangyan99
reviewed
Apr 6, 2020
| @@ -37,7 +37,7 @@ class MsalCredential(ABC): | |||
| def __init__(self, client_id, client_credential=None, **kwargs): | |||
| # type: (str, Optional[Union[str, Mapping[str, str]]], **Any) -> None | |||
| tenant_id = kwargs.pop("tenant_id", "organizations") | |||
| authority = kwargs.pop("authority", KnownAuthorities.AZURE_PUBLIC_CLOUD) | |||
| authority = kwargs.pop("authority", None) or get_default_authority() | |||
7 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added EnvVar AZURE_AUTHORITY_HOST to azure.identity._constants.
TokenCredentialOptions has an AuthorityHost property.
This will be modified to support EnvVar override with AZURE_AUTHORITY_HOST.
Azure/azure-sdk-for-java/issues/5967