Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unnecessary check for None #27

Closed
huguesv opened this issue Jun 13, 2012 · 2 comments
Closed

unnecessary check for None #27

huguesv opened this issue Jun 13, 2012 · 2 comments

Comments

@huguesv
Copy link
Contributor

huguesv commented Jun 13, 2012

In servicebusservice.py and in storageclient.py the function:

def _perform_request(self, request):

does not need to check:

if not resp:
return None

Both functions can be changed to the following:

def _perform_request(self, request):
try:
return self._filter(request)
except HTTPError as e:
return _service_bus_error_handler(e)

@weidongh
Copy link

This is fixed locally and will be included in next push to github.

@huguesv
Copy link
Contributor Author

huguesv commented Jun 13, 2012

Verified as fixed.

@huguesv huguesv closed this as completed Jun 13, 2012
RAY-316 added a commit to RAY-316/azure-sdk-for-python that referenced this issue Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants