Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security-attestation] mypy: function has duplicate type signatures #23357

Closed
kristapratico opened this issue Mar 5, 2022 · 3 comments
Closed
Labels
Attestation Client This issue points to a problem in the data-plane of the library. Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@kristapratico
Copy link
Member

There are duplicate type signatures present in this function which prevents mypy from continuing to run checks:

async def _get_signers(
self, **kwargs: Any
): # type: (Any) -> list[AttestationSigner]

This prevents customers from getting typing information from the package.

This is reproducible by running mypy==0.931 at the package level directory:

azure-sdk-for-python\sdk\attestation\azure-security-attestation>python -m mypy ./azure
azure\security\attestation\aio\_client_async.py:376: error: Function has duplicate type signatures
Found 1 error in 1 file (errors prevented further checking)
@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Attestation CXP Attention labels Mar 5, 2022
@SaurabhSharma-MSFT SaurabhSharma-MSFT added Service Attention Workflow: This issue is responsible by Azure service team. and removed CXP Attention labels Mar 7, 2022
@ghost
Copy link

ghost commented Mar 7, 2022

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @anilba06.

Issue Details

There are duplicate type signatures present in this function which prevents mypy from continuing to run checks:

async def _get_signers(
self, **kwargs: Any
): # type: (Any) -> list[AttestationSigner]

This prevents customers from getting typing information from the package.

This is reproducible by running mypy==0.931 at the package level directory:

azure-sdk-for-python\sdk\attestation\azure-security-attestation>python -m mypy ./azure
azure\security\attestation\aio\_client_async.py:376: error: Function has duplicate type signatures
Found 1 error in 1 file (errors prevented further checking)
Author: kristapratico
Assignees: -
Labels:

Service Attention, Client, Attestation

Milestone: -

@SaurabhSharma-MSFT
Copy link
Member

@kristapratico I am redirecting this to respective team to look into it for the fix.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue Mar 29, 2023
[Hub Generated] Review request for Microsoft.Help to update swagger documentation for version preview/2023-01-01-preview (Azure#23357)

* updating api spec documentation

* updating api spec documentation #2

* updating api spec documentation #3
@kristapratico
Copy link
Member Author

tracked in #32817

@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Attestation Client This issue points to a problem in the data-plane of the library. Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

No branches or pull requests

2 participants