Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] - Add live tests for SKR in KV #21174

Closed
2 tasks done
maorleger opened this issue Oct 8, 2021 · 0 comments · Fixed by #22586
Closed
2 tasks done

[KeyVault] - Add live tests for SKR in KV #21174

maorleger opened this issue Oct 8, 2021 · 0 comments · Fixed by #22586
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@maorleger
Copy link
Member

maorleger commented Oct 8, 2021

SKR is not fully supported in Key Vault, only MHSM.

Once it is available globally in KV implement the following changes:

  • Remove enableHsm conditions on mock attestation service elements in test-resources.json to install unconditionally (assuming Dynamically deploy attestation service as part of test-resources deployment #20404 is complete, disregard otherwise)
  • Ensure the same suite of tests are run against MHSM and KV (depending on your infrastructure, you might remove some annotation or you might need to duplicate the tests)
    • Note (11/5/21): Creating a key with a release policy and releasing it currently works on Key Vault and Managed HSM. However, importing a key with a release policy, or updating a key's existing release policy, work on Managed HSM but not Key Vault.
      • Importing a key with a release policy specified results in a key that has None for a release policy.
      • Updating a key's release policy fails with the following error, even when the exportable attribute isn't specified in update_key_properties: azure.core.exceptions.HttpResponseError: (BadParameter) AKV.SKR.1014: Cannot modify the exportable state of a key.
@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. KeyVault labels Oct 8, 2021
@maorleger maorleger added this to the [2021] November milestone Oct 8, 2021
@mccoyp mccoyp modified the milestones: [2021] December, [2022] January Jan 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants