Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically deploy attestation service as part of test-resources deployment #20404

Closed
maorleger opened this issue Aug 24, 2021 · 1 comment
Closed
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@maorleger
Copy link
Member

Now that we have a docker image for the attestation service we should migrate away from the statically deployed skrattestation service as per the guidelines

To do so:

  1. Take a look at the updated ARM template in this PR as a baseline https://github.com/Azure/azure-sdk-for-js/pull/16848/files#diff-4508ff3a068d9732821a84de8277596086aed8357f22dea051cd58ef808d12d1
  2. Update your ARM template to deploy a mock attestation service using the docker image hosted on azsdkengsys.
  3. Let me know what improvements we can make here to simplify things 😄

The choices I saw are:

  1. Azure App Service for containers
  2. Azure Container Instance

I went with (1) in JS because (2) does not provide SSL by default. You might choose (2) for a simpler deployment story keeping in mind the https limitation and whether your HttpClient allows insecure connections.

Finally, consider any recording sanitization that might need updating. The Key Release policy is base64url encoded, and will change depending on the authority field so I had to add extra recorder steps in JS. You might not have to.

@maorleger maorleger added Client This issue points to a problem in the data-plane of the library. KeyVault labels Aug 24, 2021
@maorleger maorleger added this to the Backlog milestone Aug 24, 2021
@mccoyp
Copy link
Member

mccoyp commented Jan 20, 2022

This was addressed in #21940 -- closing now!

@mccoyp mccoyp closed this as completed Jan 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

No branches or pull requests

2 participants