Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EventHubs] Enable skipped test #18708

Closed
yunhaoling opened this issue May 13, 2021 · 0 comments · Fixed by #18707
Closed

[EventHubs] Enable skipped test #18708

yunhaoling opened this issue May 13, 2021 · 0 comments · Fixed by #18707
Assignees
@yunhaoling
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Milestone
[2021] June

Comments

@yunhaoling
Copy link
Contributor

the following tests are skipped because they miss @pytest.mark.asyncio.
test_client_sas_credential_async
test_client_azure_sas_credential_async
test_send_batch_pid_pk_async

expected: those tests should not be skipped, we should add @pytest.mark.asyncio
@yunhaoling yunhaoling added Event Hubs Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew labels May 13, 2021
@yunhaoling yunhaoling added this to the [2021] June milestone May 13, 2021
@yunhaoling yunhaoling self-assigned this May 13, 2021
@yunhaoling yunhaoling mentioned this issue May 13, 2021
Merged
@yunhaoling yunhaoling linked a pull request May 13, 2021 that will close this issue
[EventHubs] Re-enable skipped test #18707
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-python that referenced this issue May 10, 2022
@tyler-lloyd @gossion
@karataliu @ShiqianTao @ZeroMagic @UtheMan
CodeGen from PR 18900 in Azure/azure-rest-api-specs
2a693ce 
Review request for Microsoft.ContainerService to add version 2022-04-02-preview (Azure#18900)

* Adds base for updating Microsoft.ContainerService from version preview/2022-03-02-preview to version 2022-04-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readme (Azure#18714)

* add NetworkPluginMode to ManagedCluster (Azure#18735)

* add NetworkPluginMode to ManagedCluster

* add overlay example

* remove example

* only keep overlap as option

* Add properties for apiserver-vnet-integration (Azure#18705)

* Update for AKS trusted access feature (Azure#18708)

* Update for AKS trusted access feature

* fixup! Update for AKS trusted access feature

* fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature

* OSSKU supports Windows options (Azure#18706)

* OSSKU supports Windows options

* Add example Create Agent Pool with Windows OSSKU

* Improve description about the default value

* Improve the description to clarify

* Improve description about default Windows OSSKU

* add storageProfile into managedcluster (Azure#18817)

Signed-off-by: Ji An Liu <[email protected]>

* capatalize NetworkPluginMode name (Azure#18884)

* capatalize NetworkPluginMode name

* capitalize in description

* aks: add enableCustomCATrust in v20220402-preview api-version (Azure#18830)

* aks: add enableCustomCATrust in v20220402-preview api-version

* aks: add description of CustomCATrust

* aks: fix typo, add DaemonSet to custom words list

Co-authored-by: Mikolaj Umanski <[email protected]>

* [AKS] Update on trustedaccess resource (Azure#18947)

* Add paging for trusted access

* update async state

* fixup! update async state

* Use enum for TrustedAccessRoleBinding's ProvisioningState (Azure#18950)

Co-authored-by: Tyler Lloyd <[email protected]>
Co-authored-by: gossion <[email protected]>
Co-authored-by: Dong Liu <[email protected]>
Co-authored-by: Shiqian Tao <[email protected]>
Co-authored-by: Ji'an Liu <[email protected]>
Co-authored-by: Mikołaj Umański <[email protected]>
Co-authored-by: Mikolaj Umanski <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yunhaoling yunhaoling

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs Messaging Messaging crew
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

[EventHubs] Re-enable skipped test yunhaoling/azure-sdk-for-python
1 participant
@yunhaoling